modmachine: Add machine.wake_pins.
#17542
Open
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projectgus
reviewed
Nov 20, 2025
Contributor
projectgus
left a comment
projectgus
left a comment
There was a problem hiding this comment.
This looks like a useful function to me, and a good abstraction to eventually support on other ports as well. Thanks @meirarmon!
ports/esp32/modmachine.c
Outdated
| len += (status & ((uint64_t)1 << index)) ? 1 : 0; | ||
| } | ||
| if (len) { | ||
| tuple = alloca(len * sizeof(*tuple)); |
Contributor
There was a problem hiding this comment.
Rather than using alloca here suggest doing something like:
#include "py/objtuple.h"
mp_obj_tuple_t *tuple = MP_OBJ_TO_PTR(mp_obj_new_tuple(len, NULL));
[...]
tuple->items[i] = MP_OBJ_NEW_SMALL_INT(index)
[...]
return MP_OBJ_FROM_PTR(tuple)
Contributor
Author
There was a problem hiding this comment.
@projectgus Done, shall we get this merged :-) ?
When waking from deep sleep, it could be helpful to know what pins triggered the wake up since the wake pins could be configured to multiple pins. Signed-off-by: Meir Armon <[email protected]>
meirarmon
force-pushed
the
machine-wake-pins
branch
from
34aa6c8 to
a0f3d8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When waking from deep sleep, it could be helpful to know what pins triggered the wake up since the wake pins could be configured to multiple pins.
Based on work that @m-cas did in this PR - #15498.
Testing
Tested ESP32_GENERIC_C3 with:
After wakeup checked that
machine.wake_pins()returned the correct pin that trigerred the wake.Trade-offs and Alternatives
I decided to place the method in
machinetogether withwake_reason, since it is feasible that other portswill want the exact same interface.