Skip to content

tools/verifygitlog.py: Disallow a leading slash in commit subject line. #17294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpgeorge merged 1 commit into from
May 15, 2025
Merged

tools/verifygitlog.py: Disallow a leading slash in commit subject line. #17294

dpgeorge merged 1 commit into from
May 15, 2025
+2 −2

Conversation

@dpgeorge
Copy link
Member

@dpgeorge dpgeorge commented May 13, 2025

Summary

Disallow a leading slash in commit subject line.

Prompted by #17290.

Follow up to #15823.

Testing

Tested by making a commit with a leading slash, it gives an error as expected.

@dpgeorge dpgeorge requested a review from projectgus May 13, 2025 02:46
@dpgeorge dpgeorge added the tools Relates to tools/ directory in source, or other tooling label May 13, 2025
@github-actions
Copy link

github-actions bot commented May 13, 2025

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@codecov
Copy link

codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (3b1e22c) to head (51b821c).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #17294   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         169      169           
  Lines       21897    21897           
=======================================
  Hits        21579    21579           
  Misses        318      318

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DvdGiessen DvdGiessen mentioned this pull request May 14, 2025
Merged
@dpgeorge dpgeorge force-pushed the tools-verifygitlog-disallow-leading-slash branch from ac7d534 to 51b821c Compare May 15, 2025 03:01
@dpgeorge dpgeorge merged commit 51b821c into micropython:master May 15, 2025
64 checks passed
@dpgeorge dpgeorge deleted the tools-verifygitlog-disallow-leading-slash branch May 15, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@projectgus projectgus projectgus approved these changes

Assignees

No one assigned

Labels

tools Relates to tools/ directory in source, or other tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpgeorge @projectgus