-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
py/emitinlinethumb: Use nonstring attribute to suppress compiler warnings #17215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py/emitinlinethumb: Use nonstring attribute to suppress compiler warnings #17215
Conversation
faafb2c to
a9152e9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17215 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 169 169
Lines 21890 21890
=======================================
Hits 21572 21572
Misses 318 318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a9152e9 to
0af6f58
Compare
|
Code size report: |
To suppress compiler warnings about truncated null character when initializing these fields. Signed-off-by: Damien George <[email protected]>
0af6f58 to
9735188
Compare
|
I forgot about #16692, but this PR should fix that issue. |
|
Should probably also fix the two cases in |
|
Note: In addition to Since that version isn't getting updates anymore (all development is now happening on version 2, the last release of version 1 was over 6 years ago), I think we can safely patch it. |
|
Closing in favour of #17269. |
Summary
Windows mingw CI is failing due to compiler warnings. This PR attempts to fix that.
Testing
Done by CI.