Make unix port use mp-readline library, take 2#1286
Conversation
This gets uPy readline working with unix port, with tab completion and history. GNU readline is still supported, configure using MICROPY_USE_READLINE variable.
|
There are still some issues with this. Eg, when executing a file it shouldn't set the terminal to raw mode. |
|
Tested on OS X (v 10.10.3, command line tools v 6.3). Compiles cleanly, works perfectly. |
|
@Anton-2 - Thanks, good to hear. I won't get a chance to try it until this evening - using 10.7.5, although it probably won't make a difference with compiling. |
|
Working for me, compiles, tests pass, looks good. |
|
Seems ok for msvc after implementing it's own mp_hal due to lack of termios and VT100 commands. See https://github.com/stinos/micropython/commits/unix-mp-readline-v2 |
|
Simplified and improved the handling of ctrl-C and setting of raw terminal mode, and merged in 9ae3fc6. Raw mode is now only active when doing the readline call (as per GNU readline). This makes it more compatible with original behaviour (which is CPython behaviour) and decouples raw terminal mode from ctrl-C handling. |
|
@stinos would you be able to update your patches for msvc? |
|
Yes no problem; also wanted to address to minor annoyances but need some info:
|
Ack, that's also what I have (xterm). |
Reason: my keyboard doesn't have a "delete" key (only backspace) so I never use it, hence why I never implemented it :)
Agree. |
Add support for MakerDiary nRF52840 MDK board
An improved version of #1263, which adds mp-readline to unix port, but also keeps option to use GNU readline. Default is mp-readline.
@blmorris could you please check this on OSX?
@stinos could you please check this on Windows?