Skip to content

Make unix port use mp-readline library#1263

Closed
dpgeorge wants to merge 2 commits intomasterfrom
unix-mp-readline
Closed

Make unix port use mp-readline library#1263
dpgeorge wants to merge 2 commits intomasterfrom
unix-mp-readline

Conversation

@dpgeorge
Copy link
Copy Markdown
Member

With this patch unix uses our own mp-readline library. So now it has tab completion, yay! Also has history read/write capabilities.

Hopefully addresses issue #1253.

@blmorris
Copy link
Copy Markdown
Contributor

Nice! Compiles and runs on OSX (though I still need to manually comment out #include <stdio.h> from unix/mpconfigport.h because of #1252)
Tab autocomplete working as expected.
Edit to add: tests/run-tests works also:

432 tests performed (15782 individual testcases)
432 tests passed
1 tests skipped: extra_coverage

@stinos
Copy link
Copy Markdown
Contributor

stinos commented May 18, 2015

This breaks builds for both mingw/msvc windows ports so maybe needs some #ifdefs to unbreak those until they are fixed (by providing unix_mphal.c or making it build). I thought at least mingw would have termios.h but appears it doesn't. Maybe @msiemens has an idea about the best way to fix this? For msvc I can probably come up with a winapi based solution.

@pfalcon
Copy link
Copy Markdown
Contributor

pfalcon commented May 18, 2015

We certainly want any readline support to be configurable, as @stinos suggests.

@pfalcon
Copy link
Copy Markdown
Contributor

pfalcon commented May 18, 2015

Otherwise looks good for initial version, I won't even ask why there're fgetc instead of fgets ;-).

@dpgeorge
Copy link
Copy Markdown
Member Author

Superseded by #1286.

@dpgeorge dpgeorge closed this May 24, 2015
@dpgeorge dpgeorge deleted the unix-mp-readline branch May 24, 2015 21:44
tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Oct 11, 2018
Support rev D for the Trellis M4 Express
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants