Skip to content

Commit ddc9346

Browse files
committed
esp32/machine_pin: Add new PULL_HOLD pin pull mode.
1 parent 349b545 commit ddc9346

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

ports/esp32/machine_pin.c

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@
3939
#include "machine_rtc.h"
4040
#include "modesp32.h"
4141

42+
// Used to implement gpio_hold_en() functionality; value should be distinct from all IDF pull modes
43+
#define GPIO_PULLHOLD (8)
44+
4245
typedef struct _machine_pin_obj_t {
4346
mp_obj_base_t base;
4447
gpio_num_t id;
@@ -168,7 +171,15 @@ STATIC mp_obj_t machine_pin_obj_init_helper(const machine_pin_obj_t *self, size_
168171
if (args[ARG_pull].u_obj == mp_const_none) {
169172
gpio_set_pull_mode(self->id, GPIO_FLOATING);
170173
} else {
171-
gpio_set_pull_mode(self->id, mp_obj_get_int(args[ARG_pull].u_obj));
174+
int mode = mp_obj_get_int(args[ARG_pull].u_obj);
175+
if (mode == GPIO_PULLHOLD) {
176+
gpio_hold_en(self->id);
177+
} else {
178+
if (GPIO_IS_VALID_OUTPUT_GPIO(self->id)) {
179+
gpio_hold_dis(self->id);
180+
}
181+
gpio_set_pull_mode(self->id, mode);
182+
}
172183
}
173184
}
174185

@@ -320,6 +331,7 @@ STATIC const mp_rom_map_elem_t machine_pin_locals_dict_table[] = {
320331
{ MP_ROM_QSTR(MP_QSTR_OPEN_DRAIN), MP_ROM_INT(GPIO_MODE_INPUT_OUTPUT_OD) },
321332
{ MP_ROM_QSTR(MP_QSTR_PULL_UP), MP_ROM_INT(GPIO_PULLUP_ONLY) },
322333
{ MP_ROM_QSTR(MP_QSTR_PULL_DOWN), MP_ROM_INT(GPIO_PULLDOWN_ONLY) },
334+
{ MP_ROM_QSTR(MP_QSTR_PULL_HOLD), MP_ROM_INT(GPIO_PULLHOLD) },
323335
{ MP_ROM_QSTR(MP_QSTR_IRQ_RISING), MP_ROM_INT(GPIO_PIN_INTR_POSEDGE) },
324336
{ MP_ROM_QSTR(MP_QSTR_IRQ_FALLING), MP_ROM_INT(GPIO_PIN_INTR_NEGEDGE) },
325337
{ MP_ROM_QSTR(MP_QSTR_WAKE_LOW), MP_ROM_INT(GPIO_PIN_INTR_LOLEVEL) },

0 commit comments

Comments
 (0)