Migrate to JSpecify#396
Merged
jonatan-ivanov merged 2 commits intomainfrom Aug 7, 2025
Merged
Conversation
jonatan-ivanov
commented
Jul 22, 2025
| */ | ||
| public <V> ContextRegistry registerThreadLocalAccessor(String key, Supplier<V> getSupplier, Consumer<V> setConsumer, | ||
| Runnable resetTask) { | ||
| public <V extends @Nullable Object> ContextRegistry registerThreadLocalAccessor(String key, Supplier<V> getSupplier, |
Member
Author
There was a problem hiding this comment.
This means that V can be "nullable" which lets both the supplier return null and the consumer accept null OR it can be non-nullable which means both the supplier and the consumer must return non-null. Same for getValue and setValue.
shakuzen
approved these changes
Jul 23, 2025
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Looks good to me other than the one JavaDoc issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.