Merged
Conversation
Member
|
i notice a few (most?) of the newline changes are removing newlines from text that is directly output. i.e. it’s for formatting/output style on a console. does your PR maintain that same formatting? |
Contributor
Author
I've made all but one out be md5 identical to previous - the previous output had a trailing whitespace on one line. |
korylprince
approved these changes
Jul 11, 2023
Contributor
korylprince
left a comment
korylprince
left a comment
There was a problem hiding this comment.
LGTM. I also updated the Go versions for CI and the Dockerfile, and updated the CHANGELOG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.20's
testwill fail mdmctl because of strings with trailing newlines. This PR removes the newlines, and adds 1.20 to the build matrix.I also tidied three minor complaints from staticcheck.