Skip to content

Enable Dependabot version updating.#857

Merged
jessepeterson merged 2 commits intomicromdm:mainfrom
williamtheaker:wt.dependabot
Feb 7, 2023
Merged

Enable Dependabot version updating.#857
jessepeterson merged 2 commits intomicromdm:mainfrom
williamtheaker:wt.dependabot

Conversation

@williamtheaker
Copy link
Contributor

Someone (me) pinned old versions of Github Actions, which is causing deprecation warnings in your actions: The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. & Node.js 12 actions are deprecated.. This PR enables Dependabot, which will checking for updates and open PRs to bump the pinned version for Github Actions and Go modules.

I've left the checkout action in the Docker worklow one version behind, so you can see an example Dependabot PR upon merging this branch.

I also moved gofmt to earlier in the CI run, on the assumption that you don't want to waste minutes building commits that haven't been linted.

@jessepeterson
Copy link
Member

This looks good and I'll take a closer look in a bit. But I'm curious: where do you see the deprecation warnings? When I look at the last run actions I don't (immediately) see any problems (all green checks). Anyway thanks!

@williamtheaker
Copy link
Contributor Author

Scroll to the bottom of a run like this, to the Annotations section:
https://github.com/micromdm/micromdm/actions/runs/3998500583

 Build, test & format (1.16.x, ubuntu-latest)
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-go@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Copy link
Member

@jessepeterson jessepeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jessepeterson jessepeterson merged commit ab88ade into micromdm:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants