Make dep client thread safe#850
Merged
korylprince merged 2 commits intomicromdm:mainfrom Dec 19, 2022
Merged
Conversation
When the client instance is shared between. multiple go routines, creating a session can result in 429 from Apple
korylprince
requested changes
Dec 19, 2022
Contributor
korylprince
left a comment
korylprince
left a comment
There was a problem hiding this comment.
This LGTM. Can you run gofmt (gofmt -w . in the root of the project) to appease the CI testers? Pushing a new commit or rebasing the change and force-pushing it will update this PR.
When the client instance is shared between. multiple go routines, creating a session can result in 429 from Apple
korylprince
approved these changes
Dec 19, 2022
Contributor
|
Merged after discussion with @jessepeterson. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the client instance is shared between. multiple go routines, creating a session can result in 429 from Apple