clarify mdmcert.download instructions#819
Conversation
|
The mdmcert.download addition LGTM. I think we'll need to rework the top section under |
|
So.. there's something to be said here for not mentioning mdmcert.download so as to sorta.. nudge folks to looking at obtaining an official certificate. I figure that's the original reason why they were excluded from these docs. |
|
Also - I think the docs are missing a critical step in the 'MDM CSR' workflow, too. In the CLI docs there's three steps but in the MD docs here its missing one (mdm push cert generation, I think). |
|
Finally: I'm not blocking this issue on that, just bringing up those points ;P |
I moved this to a collapsable section in order to make it more clear that they are mutually exclusive.
I was under the impression you were okay with adding more docs around mdmcert.download. If you'd rather not then that's fine too. |
Is this relevant to the mdmcert.download bits? If not, can someone address this in a separate PR? |
|
I like the collapsed section. The one issue I see left is that the new mdmcert.download section stops with downloading the certificate, when really the last step should be uploading it. You could add that as step 8, or you could break out the last section of Per @jessepeterson , the It would go before the Assuming @jessepeterson has no qualms about it, I'll merge this once the above issue is addressed. |
I've split out upload into its own section as requested. Please re-review. |
No description provided.