Fix RotateFileVaultKey panics#801
Merged
jessepeterson merged 2 commits intomicromdm:mainfrom Mar 3, 2022
Merged
Conversation
jessepeterson
added a commit
to micromdm/nanomdm
that referenced
this pull request
Mar 3, 2022
jessepeterson
approved these changes
Mar 3, 2022
Member
jessepeterson
left a comment
jessepeterson
left a comment
There was a problem hiding this comment.
lgtm. let me know if you want to update this PR or else i can merge it. :)
Contributor
Author
|
You're good to merge this one. I was actually talking about PR #785 that needs some updating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's currently an issue as noted on the MacAdmins slack with the RotateFileVaultKey command panicking in certain cases due to a edge case in the plist library.
This PR adds a test for the panic case and updates the plist library to the fixed version.