implement mdmctl apply app -sign-identity#785
Merged
groob merged 4 commits intomicromdm:mainfrom Apr 14, 2022
Merged
Conversation
Contributor
Author
|
Finally got the builders happy enough to build... That was a much longer journey than I anticipated. |
groob
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for signing packages on other OSes (any OS that supports the
xarcommand) using a .p12 identity file.The following flags are added to
mdmctl apply app:-sign-identity- path to .p12 developer identity-password- password for identity (can also be empty)-out- output path for signed package. This isn't necessarily related to multi-OS support, but is very useful and solves package overwriting if the original pkg is in/tmp.Help strings have been updated for the new flags.
I did not end up adding tests as they would have mainly just replicated the tests in go-macos-pkg. I did manually test basically every permutation of the new flags to verify functionality.
Note: if you're having weird issues trying to build, make sure you're on up to date Go. I hit this bug when pulling in go-macos-pkg.