Skip to content

Golang updates#783

Merged
groob merged 4 commits intomicromdm:mainfrom
networkpanic:go-1-17
Oct 29, 2021
Merged

Golang updates#783
groob merged 4 commits intomicromdm:mainfrom
networkpanic:go-1-17

Conversation

@networkpanic
Copy link
Contributor

This PR does:

  • update GitHub action to use 1.16/1.17
  • pins golang version in the Dockerfile
  • adds go mod tidy and module updates to go.mod
  • bump go version to 1.17

@jessepeterson
Copy link
Member

The two different requires looks odd in the go.mod. Must have been a go tidy change in the Go tools?

@networkpanic
Copy link
Contributor Author

go mod tidy moves all indirect requires to a own section

@jessepeterson
Copy link
Member

go mod tidy moves all indirect requires to a own section

Yes, I can see that. :) What I'm asking is that new? We've run go tidy many times before and this has not been the case before. :)

@networkpanic
Copy link
Contributor Author

@networkpanic
Copy link
Contributor Author

i can revert that if needed

I think it did not happen before because the go.mod was at go 1.13

@groob groob self-requested a review October 29, 2021 23:57
@groob groob merged commit 7abe029 into micromdm:main Oct 29, 2021
@networkpanic networkpanic deleted the go-1-17 branch November 3, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants