Merged
Conversation
Closed
5717f57 to
9f4da1b
Compare
a5c6e6e to
50973ac
Compare
Member
Author
|
Was able to perform a command queue on the main branch (w/o this PR), then de-queue using this PR seemingly fine. Also @korylprince put some testing into this PR, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to cleanup protobuf usage per the notes in #742. But the big one is that gogo/protobuf is unmaintained/looking for project ownership so revert to Google's protobuf library.
protoccompiler runs consistent and modern:go generatefiles using--gofast_out=to the normal compilergo generateto use--go_opt=paths=source_relativeflag to keep our invocation/directory layout.protofiles to includeoption go_package = "...";(compiler fails otherwise)protocandprotoc-gen-gomake testgo mod tidyThis needs some reasonable amount of testing to make sure everything works as expected.