Skip to content

Remove gogo/protobuf#773

Merged
jessepeterson merged 4 commits intomicromdm:mainfrom
jessepeterson:protobuf-cleanup-2021
Oct 16, 2021
Merged

Remove gogo/protobuf#773
jessepeterson merged 4 commits intomicromdm:mainfrom
jessepeterson:protobuf-cleanup-2021

Conversation

@jessepeterson
Copy link
Member

Attempt to cleanup protobuf usage per the notes in #742. But the big one is that gogo/protobuf is unmaintained/looking for project ownership so revert to Google's protobuf library.

  • Remove gogo/protobuf from all sources
  • Make all protoc compiler runs consistent and modern:
    • Change the few go generate files using --gofast_out= to the normal compiler
    • Change all go generate to use --go_opt=paths=source_relative flag to keep our invocation/directory layout
    • Change all .proto files to include option go_package = "..."; (compiler fails otherwise)
  • Regenerate all protobuf files using modern protoc and protoc-gen-go
  • Run tests make test
  • Finally, go mod tidy

This needs some reasonable amount of testing to make sure everything works as expected.

@jessepeterson
Copy link
Member Author

Was able to perform a command queue on the main branch (w/o this PR), then de-queue using this PR seemingly fine. Also @korylprince put some testing into this PR, too.

@jessepeterson jessepeterson merged commit 5daf4d1 into micromdm:main Oct 16, 2021
@jessepeterson jessepeterson deleted the protobuf-cleanup-2021 branch October 13, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant