verify_firmware_password script is using VerifyRecoveryLock. A typo?

When you're happy with this I would love to see some testing along the lines of how #743 was done (:heart: @korylprince).

If I run gofmt -s -l . now I only get info about platform/blueprint/blueprint.go but that file is not even in the commit.

Everything works as expected =)

When I checkout your branch I get:

$ gofmt -s -l .
mdm/mdm/internal/mdmproto/mdm.pb.go

Looks like that file still needs some formatting. :)

It doesn't work for me. I have updated protobuf, i have removed mdm.pb.go and generated it again, but it's still gets the same format error. Why don't my gofmt see whats wrong with mdm.pb.go and why is mdm.pb.go generated with incorrect format when the other files are correct?

This one is ready for production if anyone wants to review :)

@tomaswallentinus I'm curious how you generated the mdm.pb.go file. When I checkout your branch and just run go generate it seems to make very drastic changes (what I think is a "revert" of the changes you made). If you look at the diff it even reverts the protobuf version somehow: proto.ProtoPackageIsVersion2 from proto.ProtoPackageIsVersion3. Which tooling did you install to make it do that?

I have seen that as well. Is it because I use Ubuntu 20.04 instead of macOS maybe?

I don't think its platform dependent. How did you install the protoc tools? I have:

$ which protoc
/usr/local/bin/protoc
$ protoc --version
libprotoc 3.2.0
$ go install github.com/gogo/protobuf/[email protected]

I accualy just used: go get github.com/gogo/protobuf/protoc-gen-gofast
But I used your version install now and it generates the same file.

$which protoc
/usr/bin/protoc
$protoc --version
libprotoc 3.17.3
$go version
go version go1.16.5 linux/amd64
$cd mdm/mdm/internal/mdmproto
$rm mdm.pb.go
$go generate

And that gives me the "proto.ProtoPackageIsVersion2" line.

Not even updating protoc-gen-go to: https://github.com/protocolbuffers/protobuf-go/releases v 1.26 gives me a later version number.

Could it be a pathing issue (could you have an older protoc-gen-gofast)? My understanding is that go shells out to protoc which then shells out to protoc-gen-gfast. Could protoc be finding a different protoc-gen-gofast maybe? I can't duplicate this.

Looks like it. If I run
sudo find . -name "protoc-gen-gofast
I have:

./home/*/go/pkg/mod/github.com/gogo/[email protected]/protoc-gen-gofast
./home/*/go/bin/protoc-gen-gofast
./root/go/pkg/mod/github.com/gogo/[email protected]/protoc-gen-gofast
./root/go/bin/protoc-gen-gofast
./usr/share/gocode/src/github.com/gogo/protobuf/protoc-gen-gofast
./usr/bin/protoc-gen-gofast

I will try moving them.

O-holy-night🎷 that did it.
I needed to do:
rm /usr/bin/protoc-gen-gofast sudo mv /home/*/go/bin/protoc-gen-gofast /usr/bin/protoc-gen-gofast
Now the versionnumber in the file is 3.