Ensuring MicroMDM Logos are Hidden to assistive technologies#751
Merged
jessepeterson merged 1 commit intomicromdm:mainfrom May 5, 2021
bpmcneilly:ensuring-null-svg
Merged
Ensuring MicroMDM Logos are Hidden to assistive technologies#751jessepeterson merged 1 commit intomicromdm:mainfrom bpmcneilly:ensuring-null-svg
jessepeterson merged 1 commit intomicromdm:mainfrom
bpmcneilly:ensuring-null-svg
Conversation
Updating blank SVG to ensure that it does not receive keyboard focus / is not exposed to assistive technologies.
jessepeterson
approved these changes
May 5, 2021
Member
jessepeterson
left a comment
jessepeterson
left a comment
There was a problem hiding this comment.
Thanks @bpmcneilly! Your insight here is super appreciated, even for our modest little landing page. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #721 (I was out when I got messages from @williamtheaker), I've added a few extras to the changes proposed there.
While the SVG a11y APIs should ensure that this SVG isn't exposed to assistive technologies, I've added
aria-hidden="true"to ensure that the content is not exposed to users.Similarly, while this bug is generally windows-based, and increasingly rare, some OS / browser combinations make all SVG elements focusable via the keyboard by default, so I've added
focusable="false"to prevent that from happening in these odd corner cases.Let me know if you have any questions here!