Skip to content

Spruce up built in webpage#721

Merged
jessepeterson merged 2 commits intomicromdm:mainfrom
williamtheaker:patch-2
Apr 27, 2021
Merged

Spruce up built in webpage#721
jessepeterson merged 2 commits intomicromdm:mainfrom
williamtheaker:patch-2

Conversation

@williamtheaker
Copy link
Contributor

@williamtheaker
Copy link
Contributor Author

Screen Shot 2021-02-05 at 4 24 24 PM

@jessepeterson
Copy link
Member

Just curious: what does this look like on iOS & iPad? Just want to make sure it's usable there, too.

@williamtheaker
Copy link
Contributor Author

@rylandharris was kind enough to test on iOS devices for me.
iPad 7th generation running 14.4
iPhone XR running 14.3

image0
Image from iOS

@groob
Copy link
Member

groob commented Feb 16, 2021

Up to @jessepeterson if we want to merge this in.

I'm personally not in favor, even though it looks nice. I've been encouraging people to write their own enrollment logic and not use the built in one.

@williamtheaker
Copy link
Contributor Author

I think setting the homepage flag to false by default would be a better way to accomplish that than rejecting visual improvements.

@jessepeterson
Copy link
Member

I like the idea of the nicer home page in general. But to discourage built-in enrollment use, though, what do folks think of these options:

  1. Do nothing, merge as is.

  2. Add a new flag, disabled by default, that disables /mdm/enroll endpoint (and/or turns on a 'helpful' message like "Enrollment disabled" or something.

  3. Outright remove the 'Enroll a device' button/link from the home page (not the service itself).

  4. Disable -homepage flag by default as @williamtheaker suggested.

I don't feel super strong about this but I'm leaning toward doing 1 and then creating a new issue for 2/3. I don't really like 4. The homepage is a nice canary when first starting up MicroMDM to tell that its working and getting a 404 right off the bat could be non-intuitive for beginners. Not that MicroMDM is all that beginner friendly, heh. 🤷

@discentem
Copy link
Contributor

discentem commented Apr 22, 2021

Do nothing, merge as is.

I'd be okay with this. Overall a nicer webpage is 👍

Add a new flag, disabled by default, that disables /mdm/enroll endpoint (and/or turns on a 'helpful' message like "Enrollment disabled" or something.

This is seems like a good option. Though, to be honest, I'd be surprised if there are micromdm users out there who don't rely on the enroll webpage as a fallback.

Outright remove the 'Enroll a device' button/link from the home page (not the service itself).

Personally, I'd like to retain this option. So I'd prefer the previously mentioned flag.

Copy link
Member

@jessepeterson jessepeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a tiny page, but could we include some basic accessibility tags/attributes for the SVG? E.g. a title, description, etc. I just googled a few things seems like they'd be easy additions.

@jessepeterson
Copy link
Member

Created issue #741 for limiting default enrollment capability.

@williamtheaker
Copy link
Contributor Author

I know it's a tiny page, but could we include some basic accessibility tags/attributes for the SVG? E.g. a title, description, etc. I just googled a few things seems like they'd be easy additions.

Good call out! I didn't take that into account at all. I ran the question by accessibility consultant @bpmcneilly and was told "it should be null - assuming MicroMDM is just gonna be the alt text anyway, and that's displayed."

Copy link
Member

@jessepeterson jessepeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just update the CHANGELOG and we're good to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants