UDID Cert Auth: warn only option#643
Merged
jessepeterson merged 1 commit intomicromdm:mainfrom Aug 29, 2020
Merged
Conversation
Member
|
Can you clarify what you mean by "warn"? There's no actual warning being printed/displayed anywhere, at least as far as the diff shows. |
Member
Author
|
@groob I'm using "warn" here loosely. It already unconditionally logs here: micromdm/platform/device/udidauth.go Lines 53 to 60 in 127955d This merely stops returning errors if it's switched on. |
groob
approved these changes
Apr 18, 2020
jessepeterson
force-pushed
the
udid-cert-auth-warn-only
branch
3 times, most recently
from
2e0381f to
8969492
Compare
jessepeterson
force-pushed
the
udid-cert-auth-warn-only
branch
from
8969492 to
e302fd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the UDID Cert Auth middleware (#358) rejects connections for mismatched certificates. However, if you have a legitimate reason to allow non-matching certificates (say, you have active enrollments for which end-users renewed their own certificates) you may want to disable the connection rejection while you remediate those enrollments.
I'm not entirely convinced this should even be merged as it actively subverts a security measure. Thoughts welcome.