Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microlinkhq/metascraper
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.55.0
Choose a base ref
...
head repository: microlinkhq/metascraper
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.55.1
Choose a head ref
  • 3 commits
  • 16 files changed
  • 2 contributors

Commits on Aug 10, 2026

  1. test: refresh two tests pinned to third-party URLs that rotted (#870)

    * test(medium): refresh the logo the snapshot pins
    
    `cdn-static-1.medium.com/_/fp/icons/Medium-Avatar-500x500.svg` answers
    403 now, so the reachability check drops it and the favicon resolver
    supplies a miro.medium.com URL instead. The integration test has failed
    on master since Medium locked that host down.
    
    Only `logo` moves; every other field in the snapshot is unchanged.
    
    Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
    Claude-Session: https://claude.ai/code/session_01DiDJXMPg2e98kgL3drjg6f
    
    * test(logo-favicon): point the favicon test at a domain we control
    
    `teslahunt.io/favicon.ico` answers 404 and `cdn.teslahunt.io` no longer
    resolves at all, so the provider falls through to the Google service and
    the assertion fails. It has been red on master since.
    
    The test read as though metascraper strips the subdomain to find the
    apex favicon. It does not: it asks for `/favicon.ico` on the host it was
    given, and the apex URL in the assertion was teslahunt's own CDN
    redirect being followed. That made the test depend on a third party
    keeping both a favicon and a redirect alive.
    
    Ask microlink.io for its favicon instead — same behaviour under test,
    one less stranger in the loop.
    
    Pinning the Google fallback was the alternative and is not viable: the
    shard is per-environment, `t0` here and `t2` on CI for the same input.
    
    Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
    Claude-Session: https://claude.ai/code/session_01DiDJXMPg2e98kgL3drjg6f
    
    ---------
    
    Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
    Kikobeats and claude authored Aug 10, 2026
    Configuration menu
    Copy the full SHA
    c8cd42d View commit details
    Browse the repository at this point in the history
  2. fix(youtube): date a video by its upload date (#869)

    metascraper-youtube owned title, author, publisher and image but left
    date to the generic rules, where `$jsonld('dateCreated')` searches the
    JSON-LD tree recursively, walks into `comment[]` and answers with a
    viewer's timestamp:
    
        https://www.youtube.com/watch?v=arj7oStGLkU
        2020-05-11T19:29:04.000Z   <- a comment
        2016-04-06T16:59:35.000Z   <- the upload
    
    Declare `date` here like the other fields, read from the `uploadDate`
    the watch page carries. Vendor rules run before the generic ones, so
    YouTube no longer depends on how the shared date rules are ordered.
    
    The fixture is the watch page's own JSON-LD, comment included, with the
    commenter's details replaced. Removing the rule fails it with the exact
    production value. The snapshot test alongside it destructured `date`
    out and asserted only that it was a string, so it could not have caught
    this; pin it.
    
    The recursive search reaching into comments is a wider bug that also
    affects `review` nodes. It belongs in its own change, against
    @metascraper/helpers.
    
    
    Claude-Session: https://claude.ai/code/session_01DiDJXMPg2e98kgL3drjg6f
    
    Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
    Kikobeats and claude authored Aug 10, 2026
    Configuration menu
    Copy the full SHA
    7040d5c View commit details
    Browse the repository at this point in the history
  3. chore(release): v5.55.1

    Kikobeats committed Aug 10, 2026
    Configuration menu
    Copy the full SHA
    fd8f56c View commit details
    Browse the repository at this point in the history
Loading