Repository navigation
Commit d1ec557
fix(author): fall back to twitter:creator (#874)
* fix(author): skip UI chrome, keep real bylines
Print/share buttons and Elsevier rights links were winning
author. Reject that chrome, read twitter:creator, and collect
Co-authored-by: Cursor <[email protected]>
#author-group names when citation_author is missing.
* fix(citation): collect given-name/surname pairs
Drop the Elsevier #author-group / xocs selectors. JATS
.given-name + .surname is what the markup actually shares.
Co-authored-by: Cursor <[email protected]>
* fix(author): drop UI-chrome denylist
Site-specific Print/rights strings do not belong in isAuthor.
twitter:creator and given-name/surname already cover the cases.
Co-authored-by: Cursor <[email protected]>
* fix(author): keep only standard author markup
Drop given-name/surname HTML scraping. Sites that omit
citation_author / schema.org / twitter:creator are not
patched with publisher CSS.
Co-authored-by: Cursor <[email protected]>
* fix(author): drop toAuthorHandle
twitter: creator is always a handle; default author() already strips @
Co-authored-by: Cursor <[email protected]>
* test(author): update snapshots for twitter:creator
Co-authored-by: Cursor <[email protected]>
* test: omit flaky logo from silicon-angle snapshot
Co-authored-by: Cursor <[email protected]>
* test: assert silicon-angle logo is a URL
Co-authored-by: Cursor <[email protected]>
* test: validate destructured logos with url()
Co-authored-by: Cursor <[email protected]>
* test: allow null logo on jewish-business-news
logo-favicon only accepts ico/png; this fixture's icons are jpg
Co-authored-by: Cursor <[email protected]>
* fix(logo): read img inside itemprop=logo
Pin jewish-business-news to the HTML logo instead of a
network-dependent favicon fallback.
Co-authored-by: Cursor <[email protected]>
* test: pin HTML-only logos, drop favicon network
logo-favicon reachability is not deterministic in CI.
Co-authored-by: Cursor <[email protected]>
---------
Co-authored-by: Cursor <[email protected]>1 parent 01afe1b commit d1ec557
23 files changed
Lines changed: 59 additions & 58 deletions
File tree
- packages
- metascraper-author
- src
- test
- metascraper-logo/src
- metascraper/test/integration
- bfi/snapshots
- blogger
- business-today/snapshots
- googleblog
- jewish-business-news
- lean-data
- qz
- segment-academy
- snapshots
- segment
- silicon-angle
- snapshots
- silicon-beat
- substack
- transistor
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
35 | 38 | | |
36 | 39 | | |
37 | 40 | | |
38 | 41 | | |
39 | 42 | | |
40 | 43 | | |
41 | 44 | | |
42 | | - | |
| 45 | + | |
43 | 46 | | |
44 | 47 | | |
45 | 48 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
50 | 52 | | |
51 | 53 | | |
52 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
Binary file not shown.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | 16 | | |
19 | 17 | | |
20 | 18 | | |
| |||
28 | 26 | | |
29 | 27 | | |
30 | 28 | | |
31 | | - | |
| 29 | + | |
32 | 30 | | |
33 | 31 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
Binary file not shown.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | 16 | | |
19 | 17 | | |
20 | 18 | | |
| |||
27 | 25 | | |
28 | 26 | | |
29 | 27 | | |
| 28 | + | |
30 | 29 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 30 | | |
0 commit comments