supplement and optimize potoken related services#2129
Merged
mar-v-in merged 2 commits intomicrog:masterfrom Jan 4, 2024
Merged
supplement and optimize potoken related services#2129mar-v-in merged 2 commits intomicrog:masterfrom
mar-v-in merged 2 commits intomicrog:masterfrom
Conversation
mar-v-in
requested changes
Dec 22, 2023
Member
There was a problem hiding this comment.
Thanks for doing the changes from the previous pull request.
FYI: You can update pull requests without closing them. Just push a new commit on the branch in your fork or even force push (if you don't want to create a new commit). GitHub will handle it and update the existing pull request accordingly. This makes reviewing easier as I will immediately see what changed and can mark each change request as resolved.
play-services-api/src/main/aidl/com/google/android/gms/potokens/internal/IPoTokensService.aidl
Outdated
Show resolved
Hide resolved
mar-v-in
approved these changes
Dec 25, 2023
This was referenced Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize the PR "completing PoTokenService functions", thanks for the suggestion