Skip to content

feat(bundle): build to CommonJS and ESM, drop node <14 support #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aimee-gm merged 19 commits into from
Jun 13, 2022
Merged

feat(bundle): build to CommonJS and ESM, drop node <14 support #219

aimee-gm merged 19 commits into from
Jun 13, 2022

Conversation

@aimee-gm
Copy link
Member

@aimee-gm aimee-gm commented Jun 2, 2022 •
edited
Loading

BREAKING CHANGE

Fixes #39.

Checklist

  • Linked to any relevant issues this will close.
  • Tested the output using the demo.

Other changes

  • Switches to ESM
  • Build outputs both ECMAScript module/CommonJS bundles
  • Updates testing to support ESM
  • Updates demo to use ESM build
  • While this library may still work on node 10/12, it is no longer supported or tested since the switch to a module. As a result, this change is marked as a breaking change.

@aimee-gm aimee-gm force-pushed the esmodules branch 3 times, most recently from ea4d885 to 785a85d Compare June 2, 2022 22:00
@aimee-gm aimee-gm self-assigned this Jun 2, 2022
@aimee-gm aimee-gm changed the title Esmodules feat(bundle): build to CommonJS and ESM Jun 3, 2022
@aimee-gm
Copy link
Member Author

aimee-gm commented Jun 3, 2022

Tested with CommonJS manually

@aimee-gm aimee-gm marked this pull request as ready for review June 3, 2022 14:22
@aimee-gm aimee-gm changed the title feat(bundle): build to CommonJS and ESM feat(bundle): build to CommonJS and ESM, drop node <14 support Jun 3, 2022
@aimee-gm aimee-gm merged commit c9c33a5 into master Jun 13, 2022
@aimee-gm aimee-gm deleted the esmodules branch June 13, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aimee-gm aimee-gm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide JavaScript ES module export in distribution

2 participants

@aimee-gm