Normalize malformed OpenAI tool arguments#304
Merged
everettjf merged 1 commit intomicroclaw:mainfrom Mar 30, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens OpenAI-compatible streaming and request translation against malformed tool-call argument payloads from certain providers, ensuring tool inputs are consistently normalized before being sent back to chat-completions / responses endpoints.
Changes:
- Ignore empty/null trailing
tool_callsstreaming chunks (id/name/arguments) so they don’t corrupt previously collected tool-call state. - Normalize
ContentBlock::ToolUse.inputinto a JSON object (or{}) when building OpenAI request payloads, including handling historically stringified JSON. - Add regression tests covering MiniMax/Qwen stream parsing and request-side tool argument sanitization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thank you. I will check later today |
Contributor
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan