fix(reflector): strip thinking tags from message content before LLM p…#303
Merged
everettjf merged 2 commits intomicroclaw:mainfrom Mar 30, 2026
Merged
Conversation
everettjf
reviewed
Mar 30, 2026
everettjf
reviewed
Mar 30, 2026
Contributor
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The nightly reflector task was failing with JSON parse errors. Investigation showed that message content containing
<thinking>tags (from extended reasoning models) was being passed directly to the LLM. The LLM's output would then contain confused/mixed XML-like structures, breaking the JSON parser.Solution
Strip
<thinking>,<notepad>, and<thought>tags from message content before including it in the LLM prompt — matching what the web UI already does for normal responses.Changes
src/scheduler.rs: Applystrip_reflector_thinking_tags()to message content inreflect_for_chat()Testing