Skip to content

chore: Removed some unncessary null checks from 'test.go'#131

Merged
lbroudoux merged 2 commits intomicrocks:1.xfrom
Harsh4902:1.x
Mar 21, 2025
Merged

chore: Removed some unncessary null checks from 'test.go'#131
lbroudoux merged 2 commits intomicrocks:1.xfrom
Harsh4902:1.x

Conversation

@Harsh4902
Copy link
Copy Markdown
Member

Description

  • This PR removes some unnecessary null checks and unused timeUnitChoice map from test.go file.

Related issue(s)

@Harsh4902
Copy link
Copy Markdown
Member Author

@lbroudoux Please don't merge it. I am still doing some cleanup work.

@Harsh4902
Copy link
Copy Markdown
Member Author

@lbroudoux Now it's done.

@lbroudoux lbroudoux added this to the 1.0.0 milestone Mar 21, 2025
@lbroudoux lbroudoux added the kind/task Project maintenance task label Mar 21, 2025
Copy link
Copy Markdown
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbroudoux lbroudoux merged commit 1a3de0f into microcks:1.x Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/task Project maintenance task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants