Skip to content

Fix get_actual_qos methods (backport #292)#294

Merged
pablogs9 merged 2 commits intofoxyfrom
mergify/bp/foxy/pr-292
Mar 23, 2023
Merged

Fix get_actual_qos methods (backport #292)#294
pablogs9 merged 2 commits intofoxyfrom
mergify/bp/foxy/pr-292

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Mar 21, 2023

This is an automatic backport of pull request #292 done by Mergify.
Cherry-pick of 7886a89 has failed:

On branch mergify/bp/foxy/pr-292
Your branch is up to date with 'origin/foxy'.

You are currently cherry-picking commit 7886a89.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rmw_microxrcedds_c/src/rmw_client.c
	both modified:   rmw_microxrcedds_c/src/rmw_publisher.c
	both modified:   rmw_microxrcedds_c/src/rmw_service.c
	both modified:   rmw_microxrcedds_c/src/rmw_subscription.c

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@Acuadros95 @mergify
Fix QoS getter (#292)
bbb639f 
Signed-off-by: acuadros95 <[email protected]>
(cherry picked from commit 7886a89)

# Conflicts:
#	rmw_microxrcedds_c/src/rmw_client.c
#	rmw_microxrcedds_c/src/rmw_publisher.c
#	rmw_microxrcedds_c/src/rmw_service.c
#	rmw_microxrcedds_c/src/rmw_subscription.c
@mergify mergify Bot added the conflicts label Mar 21, 2023
@mergify mergify Bot mentioned this pull request Mar 21, 2023
Merged
@Acuadros95
Fix conflicts
81f3b73 
Signed-off-by: acuadros95 <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 21, 2023

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 272 B
Publisher 4 280 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34436 B

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (d60c349) 48.76% compared to head (88e3cf8) 48.65%.

❗ Current head 88e3cf8 differs from pull request most recent head 81f3b73. Consider uploading reports for the commit 81f3b73 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             foxy     #294      +/-   ##
==========================================
- Coverage   48.76%   48.65%   -0.12%     
==========================================
  Files          41       41              
  Lines        1700     1704       +4     
  Branches      501      505       +4     
==========================================
  Hits          829      829              
- Misses        639      643       +4     
  Partials      232      232
Impacted Files Coverage Δ
rmw_microxrcedds_c/src/rmw_publisher.c 47.36% <0.00%> (-0.73%) ⬇️
rmw_microxrcedds_c/src/rmw_subscription.c 52.51% <0.00%> (-0.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pablogs9 pablogs9 merged commit 93b6dc1 into foxy Mar 23, 2023
@pablogs9 pablogs9 deleted the mergify/bp/foxy/pr-292 branch March 23, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Acuadros95 Acuadros95 Acuadros95 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codecov-commenter @Acuadros95 @pablogs9