WiFiEspAT Support#1425
Merged
Acuadros95 merged 13 commits intomicro-ROS:humblefrom Jun 28, 2023
maehara-keisuke:feature/add-wifiespat-support
Merged
WiFiEspAT Support#1425Acuadros95 merged 13 commits intomicro-ROS:humblefrom maehara-keisuke:feature/add-wifiespat-support
Acuadros95 merged 13 commits intomicro-ROS:humblefrom
maehara-keisuke:feature/add-wifiespat-support
Conversation
Signed-off-by: maehara-keisuke <[email protected]>
Signed-off-by: maehara-keisuke <[email protected]>
Signed-off-by: maehara-keisuke <[email protected]>
Signed-off-by: maehara-keisuke <[email protected]>
Signed-off-by: maehara-keisuke <[email protected]>
Signed-off-by: maehara-keisuke <[email protected]>
pablogs9
reviewed
Jun 19, 2023
Member
|
BTW, thanks a lot for this great work! |
Contributor
Author
Thank you for your reviewing. I'll plan to modify. |
Signed-off-by: maehara-keisuke <[email protected]>
Signed-off-by: maehara-keisuke <[email protected]>
Signed-off-by: maehara-keisuke <[email protected]>
Signed-off-by: maehara-keisuke <[email protected]>
Signed-off-by: maehara-keisuke <[email protected]>
Signed-off-by: maehara-keisuke <[email protected]>
Contributor
Author
|
I confirmed to work properly with each board. |
Acuadros95
suggested changes
Jun 27, 2023
Contributor
Acuadros95
left a comment
Acuadros95
left a comment
There was a problem hiding this comment.
Minor comments, the rest LGTM
Co-authored-by: Antonio Cuadros <[email protected]>
Contributor
Author
Thanks for your suggestion. I reflected it. |
Acuadros95
approved these changes
Jun 28, 2023
pablogs9
approved these changes
Jun 28, 2023
Contributor
|
@mergify backport rolling iron |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Extend set_microros_wifi_transport(). Signed-off-by: maehara-keisuke <[email protected]> * Enable each function if BOARD_WITH_ESP_AT is defined. Signed-off-by: maehara-keisuke <[email protected]> * Enable to compile publisher_wifi example if USE_WIFI_ESP_AT is defined. Signed-off-by: maehara-keisuke <[email protected]> * Follow CI. Signed-off-by: maehara-keisuke <[email protected]> * Markdown table formattings. Signed-off-by: maehara-keisuke <[email protected]> * Add section for ESP-AT module. Signed-off-by: maehara-keisuke <[email protected]> * Revert micro-ros_publisher_wifi. Signed-off-by: maehara-keisuke <[email protected]> * Minor: fix typo. Signed-off-by: maehara-keisuke <[email protected]> * Add new example for ESP-AT. Signed-off-by: maehara-keisuke <[email protected]> * Follow CI. Signed-off-by: maehara-keisuke <[email protected]> * Simplify description about ESP-AT supported boards. Signed-off-by: maehara-keisuke <[email protected]> * Remove unnecessary build test. Co-authored-by: Antonio Cuadros <[email protected]> --------- Signed-off-by: maehara-keisuke <[email protected]> Co-authored-by: Antonio Cuadros <[email protected]> (cherry picked from commit f78b91c)
mergify Bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Extend set_microros_wifi_transport(). Signed-off-by: maehara-keisuke <[email protected]> * Enable each function if BOARD_WITH_ESP_AT is defined. Signed-off-by: maehara-keisuke <[email protected]> * Enable to compile publisher_wifi example if USE_WIFI_ESP_AT is defined. Signed-off-by: maehara-keisuke <[email protected]> * Follow CI. Signed-off-by: maehara-keisuke <[email protected]> * Markdown table formattings. Signed-off-by: maehara-keisuke <[email protected]> * Add section for ESP-AT module. Signed-off-by: maehara-keisuke <[email protected]> * Revert micro-ros_publisher_wifi. Signed-off-by: maehara-keisuke <[email protected]> * Minor: fix typo. Signed-off-by: maehara-keisuke <[email protected]> * Add new example for ESP-AT. Signed-off-by: maehara-keisuke <[email protected]> * Follow CI. Signed-off-by: maehara-keisuke <[email protected]> * Simplify description about ESP-AT supported boards. Signed-off-by: maehara-keisuke <[email protected]> * Remove unnecessary build test. Co-authored-by: Antonio Cuadros <[email protected]> --------- Signed-off-by: maehara-keisuke <[email protected]> Co-authored-by: Antonio Cuadros <[email protected]> (cherry picked from commit f78b91c)
Acuadros95
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Extend set_microros_wifi_transport(). Signed-off-by: maehara-keisuke <[email protected]> * Enable each function if BOARD_WITH_ESP_AT is defined. Signed-off-by: maehara-keisuke <[email protected]> * Enable to compile publisher_wifi example if USE_WIFI_ESP_AT is defined. Signed-off-by: maehara-keisuke <[email protected]> * Follow CI. Signed-off-by: maehara-keisuke <[email protected]> * Markdown table formattings. Signed-off-by: maehara-keisuke <[email protected]> * Add section for ESP-AT module. Signed-off-by: maehara-keisuke <[email protected]> * Revert micro-ros_publisher_wifi. Signed-off-by: maehara-keisuke <[email protected]> * Minor: fix typo. Signed-off-by: maehara-keisuke <[email protected]> * Add new example for ESP-AT. Signed-off-by: maehara-keisuke <[email protected]> * Follow CI. Signed-off-by: maehara-keisuke <[email protected]> * Simplify description about ESP-AT supported boards. Signed-off-by: maehara-keisuke <[email protected]> * Remove unnecessary build test. Co-authored-by: Antonio Cuadros <[email protected]> --------- Signed-off-by: maehara-keisuke <[email protected]> Co-authored-by: Antonio Cuadros <[email protected]> (cherry picked from commit f78b91c) Co-authored-by: maehara-keisuke <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I changed
micro-ros_publisher_wifiexample in the following cases.What I tested
micro-ros_publisher_wifiexample for boards below and Run successfully.Raspberry Pi Picoraspberrypi_pico.mp4
Seeed Studio XIAO SAMD21seeed_studio_xiao_samd21.mp4
Seeed Studio XIAO RP2040seeed_studio_xiao_rp2040.mp4