Skip to content

fix ethernet udp ping agent#1094

Merged
Acuadros95 merged 1 commit intomicro-ROS:foxyfrom
Jenifen:foxy
Jul 20, 2022
Merged

fix ethernet udp ping agent#1094
Acuadros95 merged 1 commit intomicro-ROS:foxyfrom
Jenifen:foxy

Conversation

@Jenifen
Copy link
Copy Markdown
Contributor

@Jenifen Jenifen commented Jul 19, 2022

related #1072

@Jenifen
Copy link
Copy Markdown
Contributor Author

Jenifen commented Jul 19, 2022

if sent = 1 == udp_client.endPacket() ? sent : 0; required for the Teensy or STM might we need to add a check which hardware defined ?

@adityakamath
Copy link
Copy Markdown
Contributor

I tested it with Teensy 4.1 and it works. The defined hardware check is not needed here. Not sure for STM

@Acuadros95
Copy link
Copy Markdown
Contributor

STM board support was added here #593 with a platformIO project as target.

PlatformIO has been deprecated and moved to micro-ROS for PlatformIO so I think we are good to go.

Thanks for the fix!

@Acuadros95 Acuadros95 merged commit b15bbcd into micro-ROS:foxy Jul 20, 2022
@Acuadros95
Copy link
Copy Markdown
Contributor

@mergify backport humble galactic main

mergify Bot pushed a commit that referenced this pull request Jul 20, 2022
(cherry picked from commit b15bbcd)
mergify Bot pushed a commit that referenced this pull request Jul 20, 2022
(cherry picked from commit b15bbcd)
mergify Bot pushed a commit that referenced this pull request Jul 20, 2022
(cherry picked from commit b15bbcd)
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 20, 2022

backport humble galactic main

✅ Backports have been created

Details

Acuadros95 pushed a commit that referenced this pull request Jul 20, 2022
(cherry picked from commit b15bbcd)

Co-authored-by: Seifeddin <[email protected]>
Acuadros95 pushed a commit that referenced this pull request Jul 20, 2022
(cherry picked from commit b15bbcd)

Co-authored-by: Seifeddin <[email protected]>
Acuadros95 pushed a commit that referenced this pull request Jul 20, 2022
(cherry picked from commit b15bbcd)

Co-authored-by: Seifeddin <[email protected]>
@Jenifen Jenifen deleted the foxy branch July 20, 2022 16:05
@Jenifen Jenifen restored the foxy branch July 20, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants