feat: bump adbc-driver-postgresql>=1.9.0 and Python>=3.10.0 #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
force-pushed
the
feat/drop-support-older-adbc-driver-postgresql
branch
from
9c2fa3a to
88731e1
Compare
michalc
changed the title
michalc
force-pushed
the
feat/drop-support-older-adbc-driver-postgresql
branch
from
88731e1 to
a082d8b
Compare
This increases the minimum version of adbc-driver-postgresql to 1.9.0. While we could support older versions still - We run up against GitHub actions limits by trying to test absolutely every version. Assuming adbc-driver-postgresql is semver, each minor version is backward compatible, so it shouldn't be a problem for client code to upgrade. - And it makes it easier in documentation, tests, and suspect future code that we can assume that apache/arrow-adbc#3579 is part of adbc-driver-postgresql, which allows preparing queries to return as-accurate-as-possible type information for bind parameters in queries, which addresses at least in part the issues raised in apache/arrow-adbc#2865 (comment) This itself requires a bump to the minimum version of Python to 3.10.0. While slightly unfortunate, Python 3.9 is EOL at the time of writing, and can't support everything for ever: suspect there are better ways to use time.
michalc
force-pushed
the
feat/drop-support-older-adbc-driver-postgresql
branch
from
a082d8b to
a321433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the minimum version of adbc-driver-postgresql to 1.9.0. While we could support older versions still
We run up against GitHub actions limits by trying to test absolutely every version. Assuming adbc-driver-postgresql is semver, each minor version is backward compatible, so it shouldn't be a problem for client code to upgrade.
And it makes it easier in documentation, tests, and suspect future code that we can assume that feat(c/driver/postgresql): Implement StatementGetParameterSchema apache/arrow-adbc#3579 is part of adbc-driver-postgresql, which allows preparing queries to return as-accurate-as-possible type information for bind parameters in queries, which addresses at least in part the issues raised in Querying PostgreSQL generate_subscripts from Python with a dimension from bound parameters apache/arrow-adbc#2865 (comment)
This itself requires a bump to the minimum version of Python to 3.10.0. While slightly unfortunate, Python 3.9 is EOL at the time of writing, and can't support everything for ever: suspect there are better ways to use time