Repository navigation
Commit 7cb2f16
Require the Node that does not crash mid-suite on Windows (#247)
The browser suite's dev server died in about 30% of runs under load on
Windows, and the cause was a stack buffer overrun inside node.exe's TCP
code, not anything here: a v24.15.0 regression that upstream fixed in
v24.16.0 (nodejs/node#62991). Measured on this machine, pinned to two
cores: 6 deaths in 20 runs on v24.15.0, 0 in 10 on v24.20.0 with all 105
tests passing each time.
So `engines` asks for `^24.16` rather than `>=22.12`. Bounded to the 24
line because Node stopped distributing corepack in v25, which every
setup instruction here depends on for the pnpm version.
`engines` alone only warns — pnpm prints "WARN Unsupported engine" and
installs anyway — so `.npmrc` sets `engine-strict=true`, which is what
makes the floor hold. The test explorer's own `engines` goes: it is
private and only ever run from the workspace root, so the root's
governs and the claim exists in one place.
Closes #207
Co-authored-by: Claude Opus 5 <[email protected]>1 parent 7209b8e commit 7cb2f16
6 files changed
Lines changed: 18 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
| 44 | + | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| |||
245 | 246 | | |
246 | 247 | | |
247 | 248 | | |
248 | | - | |
| 249 | + | |
249 | 250 | | |
250 | 251 | | |
251 | 252 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | 7 | | |
11 | 8 | | |
12 | 9 | | |
| |||
0 commit comments