Perform v9 migration less-atomically#3
Merged
michaelsproul merged 4 commits intomichaelsproul:db-payload-separationfrom May 11, 2022
Merged
Perform v9 migration less-atomically#3michaelsproul merged 4 commits intomichaelsproul:db-payload-separationfrom
michaelsproul merged 4 commits intomichaelsproul:db-payload-separationfrom
Conversation
michaelsproul
pushed a commit
that referenced
this pull request
Nov 3, 2023
…gregation Fix compute_neighbourhoods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Performs each block in the migration separately, rather than the entire operation. This helps to reduce the memory footprint of this operation from ~10GB to ~1GB.
Some new logic has been added to detect when a block has already been migrated, this allows recovery from a partial migration (e.g., Ctrl+C halfway through the migration).
I've swapped iterating the keys of the database rather than keys + values. This isn't strictly necessary and I'm not sure if it has an impact on memory usage, but I've kept it around since:
try_get_full_block) rather than dealing with SSZ bytes directly.I'm not attached to the key iterator though, I could take it or leave it.