Skip to content

Fix redirect_to URL since WordPress 6 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jrchamp merged 5 commits into from
Mar 20, 2023
Merged

Fix redirect_to URL since WordPress 6 #88

jrchamp merged 5 commits into from
Mar 20, 2023

Conversation

@masteradhoc
Copy link
Contributor

@masteradhoc masteradhoc commented Mar 16, 2023 •
edited by jrchamp
Loading

Fixes #86

@jrchamp
Copy link
Collaborator

jrchamp commented Mar 16, 2023

Hi @masteradhoc

It looks like this Pull Request is incorrectly modifying line 534:

shibboleth/shibboleth.php

Line 534 in f9bae44

if ( ! empty( $redirect ) ) {

Instead, it should probably be updating line 962 (as mentioned in #86):

shibboleth/shibboleth.php

Line 962 in f9bae44

if ( isset( $wp->request ) ) {

@masteradhoc
Copy link
Contributor Author

masteradhoc commented Mar 17, 2023

@jrchamp thanks! adjusted it now

@jrchamp jrchamp merged commit efb85af into michaelryanmcneill:master Mar 20, 2023
@jrchamp jrchamp changed the title Fix redirect_to URL since Wordpress 6 Fix redirect_to URL since WordPress 6 Mar 20, 2023
@masteradhoc masteradhoc deleted the patch-1 branch March 20, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect redirect_to URL since WordPress 6

2 participants

@masteradhoc @jrchamp