add option to disable account creation if no mapped roles or default role#59
Conversation
jrchamp
left a comment
jrchamp
left a comment
There was a problem hiding this comment.
This looks really good to me. I want to know your thoughts on adding underscores to the noaccount role to indicate that it's a reserved word, like _no_account. I'm not sure if I prefer with or without the extra literal spaces around the inline selected(), nor how I would alter the "Do NOT" language to make it less loud.
|
Added a new commit to change the "noaccount" name to "_no_account"; I think that's better. I also made an update to the I agree, the "Do NOT" label is pretty harsh sounding - definitely open to other label names. "Prevent account creation"? Or maybe add "(none)" to the label as well to give it juxtaposition to the existing "(none)", e.g. "(none) - prevent account creation". Any other ideas? I'm pretty new to plugin development, so I appreciate all the feedback! |
|
Comparing this to the existing "(none)", I think the parentheses imbues special meaning. As far as meaning, choosing this option will mean that:
Conversely as positives:
Perhaps "(skip 'no role' account creation)" or "(none) and skip '(none)' account creation"? Part of me wants to rename the "(none)" item to "(no role)"... Hopefully these ideas help somewhat. Ultimately, I think you're on the right track and whatever you decide is probably best. 👍 Thank you for your contributions on this @dandalpiaz ! |
jrchamp
left a comment
jrchamp
left a comment
There was a problem hiding this comment.
This is easily the simplest solution I've seen to address #51
Thank you @dandalpiaz for providing this.
|
Tested this pull request on a system I work with and it works as promised, thanks @dandalpiaz. I'll use this version starting next week up until a new release with this included is ready. |
4 participants
No description provided.