Skip to content

2.1 release #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelryanmcneill merged 71 commits into from
May 16, 2018
Merged

2.1 release #47

michaelryanmcneill merged 71 commits into from
May 16, 2018

Conversation

@michaelryanmcneill
Copy link
Owner

@michaelryanmcneill michaelryanmcneill commented May 16, 2018

No description provided.

@michaelryanmcneill
Updating changelog and version to 2.1-alpha
b2ae374
@michaelryanmcneill
Fixing a regression introduced by #44
b5637f0
@michaelryanmcneill
Sleep deprivation does wonders for your PHP knowledge
066c33c
@michaelryanmcneill
Adding logging tab for #31
8825ec5
@michaelryanmcneill
Adding title for #31
a701b31
@michaelryanmcneill
Adding various options in the admin interface for #31
264ed23
@michaelryanmcneill
Grabbing options for #31
78637f9
@michaelryanmcneill
Adding update_site_option for #31
4ab0b29
@michaelryanmcneill
Adding checkbox details for #31
7b7b8b4
@michaelryanmcneill
Making some changes to reduce the options footprint for #31
b7b2c57
@michaelryanmcneill
Making some changes to reduce the options footprint for #31
30439c1
@michaelryanmcneill
Making some changes to reduce the options footprint for #31 for the t…
af0b54a 
…hird time
@michaelryanmcneill
Adding final touches to admin interface for logging
10094a8
@michaelryanmcneill
Making major changes to streamline option access
683a747
@michaelryanmcneill
Fixing typo
0d6d003
@michaelryanmcneill
Fixing backwards parameters
8d4025e
@michaelryanmcneill
Adding simple comments to explain the logic
02bc03c
@michaelryanmcneill
Adding multiple changes
c56178e 
Adding documentation/comments to various functions
Disabling password reset and password changes if local auth is disabled (#28)
Adding inital support for custom prefixes (#27)
@michaelryanmcneill
Fixing missing }
ab4b4b8
@michaelryanmcneill
Fixing order to allow resets to be disabled before dying
7314bc3
@michaelryanmcneill
Properly disabling password resets from wp-login.php
06c28be
@michaelryanmcneill
Changing password reset URL if specified
5a5f5ca
@michaelryanmcneill
Disabling password resets for frontend forms too
16f4b4f
@michaelryanmcneill
Updating readme changelog; closes #28
7c48dfe
@michaelryanmcneill
Adding new case insensitive matching (#39)
0c2b216
@michaelryanmcneill
Fixing mistake commit
fd45a10
@michaelryanmcneill
Trying to test regression
8311942
@michaelryanmcneill
Possibly fixing regression
8087a08
@michaelryanmcneill
Fixing regression entirely
3e70330
@michaelryanmcneill
Making email comparisons for manual account merging case insensitive
73b62a6 
Closes #39
Michael McNeill and others added 26 commits May 16, 2018 11:01
Fixing missing ;
fff3f7f
Adding additional details to the Attribute Access option
df032bb
Fixing my poor grammar
09360ce
Fixes missing , thanks @jrchamp
1a27196
Fixing apply_filters() being called on the wrong option, thanks @jrchamp
9158d6e
Escaping output to be safe
4a8f9f9
@jrchamp
shibboleth_getoption: Simplify code
6a360b6
Would help if I acutally used the right option
508075e
@jrchamp
options: Remove uses of extract()
2bea3d4
Trying to prevent breaking the password reset URL
d6bf852
Fixing broken lost password URL
9679ac2
@michaelryanmcneill
Merge pull request #45 from jrchamp/patch-5
74f3433 
shibboleth_getoption: Simplify code
@michaelryanmcneill
Merge pull request #46 from jrchamp/patch-6
3b47b66 
options: Remove uses of extract()
Fixes inadvertent issue caused by list() via #46
cfde1dc
Adding the ability to still reference the value and constant keys
8419411
Changing to esc_attr instead of esc_html
b958e8b
Adding some tooltip clarification
8879ad6
Adding logging configuration and functionality for #31
d757a92
Fixing syntax error
d9a8adb
Fixing a deprecation warning and small changes for non-specified roles
18fbbce
Fixing my typo...
62bde6e
Fixing deprecation warning of registration.php and adding NULL for us…
79bb771 
…er_pass
Fixing PHP warnings from bool not matching array
5942e49
Changing from application/javascript to text/javascript, thanks @jrchamp
8515b62
Updating readme.txt
abd76e5
Bumping version
85fb8df
@michaelryanmcneill
Copy link
Owner Author

michaelryanmcneill commented May 16, 2018

Thanks @jrchamp for all your help on this release!

@michaelryanmcneill michaelryanmcneill merged commit 3c7c97d into master May 16, 2018
@michaelryanmcneill michaelryanmcneill deleted the 2.1-alpha branch May 16, 2018 19:56
jrchamp
jrchamp reviewed May 16, 2018
View reviewed changes
options-admin.php
case 'logging' :
$constant = false;
list( $shib_logging, $shib_logging_constant ) = shibboleth_getoption( 'shibboleth_logging', true, false, true );
list( $shib_logging, $shib_logging_constant ) = shibboleth_getoption( 'shibboleth_logging', array(), false, true );
Copy link
Collaborator

@jrchamp jrchamp May 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking this should be array(), true, true. All the other ones that have a default value of array() are immediately followed by true

Copy link
Owner Author

@michaelryanmcneill michaelryanmcneill May 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct, I'll fix this in the dot release as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrchamp jrchamp jrchamp left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelryanmcneill @jrchamp