Repository navigation
Suggestions to simplify and better document time-concatenate - #30
Merged
mhvk merged 1 commit intoMay 29, 2025
Merged
Conversation
1 task done
mhvk
approved these changes
May 29, 2025
mhvk
left a comment
mhvk
left a comment
Owner
There was a problem hiding this comment.
Yes, that's nice!
I ran out of time when preparing the PR, hence the somewhat incomplete tests (but still wanted it out there...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to make suggestions on the
zeros_likefunction implementation.This is passing the existing tests, but I note that there is no coverage for additional attributes like
in_subfmtetc.