Selector: Use shallow equality to compare documents to avoid IE/Edge crashes

mgol · mgol · commit 53d084000bdb · 2019-08-27T01:57:23.000+02:00
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Fixes jquerygh-4441
diff --git a/src/selector.js b/src/selector.js
@@ -154,6 +154,15 @@ function selectorError( msg ) {
 	throw new Error( "Syntax error, unrecognized expression: " + msg );
 }
 
+function areSameDocs( doc1, doc2 ) {
+
+	// Support: IE 11+, Edge 17 - 18+
+	// IE/Edge sometimes throw a "Permission denied" error when strict-comparing
+	// two documents; shallow comparisons work.
+	// eslint-disable-next-line eqeqeq
+	return doc1 == doc2;
+}
+
 function find( selector, context, results, seed ) {
 	var m, i, elem, nid, match, groups, newSelector,
 		newContext = context && context.ownerDocument,
@@ -173,7 +182,10 @@ function find( selector, context, results, seed ) {
 	// Try to shortcut find operations (as opposed to filters) in HTML documents
 	if ( !seed ) {
 
-		if ( ( context ? context.ownerDocument || context : preferredDoc ) !== document ) {
+		if ( !areSameDocs(
+			context ? context.ownerDocument || context : preferredDoc,
+			document
+		) ) {
 			setDocument( context );
 		}
 		context = context || document;
@@ -425,7 +437,7 @@ function setDocument( node ) {
 		doc = node ? node.ownerDocument || node : preferredDoc;
 
 	// Return early if doc is invalid or already selected
-	if ( doc === document || doc.nodeType !== 9 ) {
+	if ( areSameDocs( doc, document ) || doc.nodeType !== 9 ) {
 		return;
 	}
 
@@ -436,7 +448,7 @@ function setDocument( node ) {
 
 	// Support: IE 9 - 11+, Edge 12 - 18+
 	// Accessing iframe documents after unload throws "permission denied" errors (jQuery #13936)
-	if ( preferredDoc !== document &&
+	if ( !areSameDocs( preferredDoc, document ) &&
 		( subWindow = document.defaultView ) && subWindow.top !== subWindow ) {
 
 		// Support: IE 9 - 11+, Edge 12 - 18+
@@ -451,7 +463,7 @@ find.matches = function( expr, elements ) {
 find.matchesSelector = function( elem, expr ) {
 
 	// Set document vars if needed
-	if ( ( elem.ownerDocument || elem ) !== document ) {
+	if ( !areSameDocs( elem.ownerDocument || elem, document ) ) {
 		setDocument( elem );
 	}
 
@@ -1413,14 +1425,15 @@ function matcherFromGroupMatchers( elementMatchers, setMatchers ) {
 				dirrunsUnique = ( dirruns += contextBackup == null ? 1 : Math.random() || 0.1 );
 
 			if ( outermost ) {
-				outermostContext = context === document || context || outermost;
+				outermostContext = areSameDocs( context, document ) || context || outermost;
 			}
 
 			// Add elements passing elementMatchers directly to results
 			for ( ; ( elem = elems[ i ] ) != null; i++ ) {
 				if ( byElement && elem ) {
 					j = 0;
-					if ( !context && elem.ownerDocument !== document ) {
+
+					if ( !context && !areSameDocs( elem.ownerDocument, document ) ) {
 						setDocument( elem );
 						xml = !documentIsHTML;
 					}
