Repository navigation
Commit 92f4e8f
authored
add ExecutionPlan::dynamic_expressions_produced() method (apache#24068)
## Which issue does this PR close?
- Closes: apache#23814
- Closes:
datafusion-contrib/datafusion-distributed#584
## Rationale for this change
External users who wish to propagate dynamic filter updates across
network boundaries need to know in which direction updates need to flow.
Thus `ExecutionPlan::apply_expressions` is not enough. The proposal in
apache#23814 is to provide a
separate API for dynamic filter producers.
## What changes are included in this PR?
This change adds a new method
`ExecutionPlan::dynamic_expressions_produced(&self) -> Vec<Arc<dyn
PhysicalExpr>>` which should return dynamic filters produced by the
`ExecutionPlan`.
## Are these changes tested?
Yes. Adds a new invariant that all expressions returned by
`ExecutionPlan::dynamic_expressions_produced` have an expression id.
## Are there any user-facing changes?
There's a new API, `ExecutionPlan::dynamic_expressions_produced(&self)
-> Vec<Arc<dyn PhysicalExpr>>`1 parent e2e8e1c commit 92f4e8f
10 files changed
Lines changed: 380 additions & 57 deletions
File tree
- datafusion
- core/tests/physical_optimizer
- ffi
- src
- physical_expr
- tests
- tests
- physical-plan/src
- aggregates
- joins/hash_join
- sorts
- proto/tests/cases
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
38 | 42 | | |
39 | 43 | | |
40 | 44 | | |
| |||
60 | 64 | | |
61 | 65 | | |
62 | 66 | | |
| 67 | + | |
63 | 68 | | |
64 | 69 | | |
65 | 70 | | |
| |||
2914 | 2919 | | |
2915 | 2920 | | |
2916 | 2921 | | |
2917 | | - | |
2918 | | - | |
| 2922 | + | |
| 2923 | + | |
2919 | 2924 | | |
2920 | 2925 | | |
2921 | 2926 | | |
2922 | 2927 | | |
| 2928 | + | |
| 2929 | + | |
| 2930 | + | |
| 2931 | + | |
2923 | 2932 | | |
2924 | 2933 | | |
2925 | 2934 | | |
| |||
3101 | 3110 | | |
3102 | 3111 | | |
3103 | 3112 | | |
| 3113 | + | |
| 3114 | + | |
| 3115 | + | |
| 3116 | + | |
| 3117 | + | |
| 3118 | + | |
| 3119 | + | |
| 3120 | + | |
| 3121 | + | |
| 3122 | + | |
| 3123 | + | |
| 3124 | + | |
| 3125 | + | |
| 3126 | + | |
| 3127 | + | |
| 3128 | + | |
| 3129 | + | |
| 3130 | + | |
| 3131 | + | |
| 3132 | + | |
| 3133 | + | |
| 3134 | + | |
| 3135 | + | |
| 3136 | + | |
| 3137 | + | |
| 3138 | + | |
| 3139 | + | |
| 3140 | + | |
| 3141 | + | |
| 3142 | + | |
| 3143 | + | |
| 3144 | + | |
| 3145 | + | |
| 3146 | + | |
| 3147 | + | |
| 3148 | + | |
| 3149 | + | |
| 3150 | + | |
| 3151 | + | |
| 3152 | + | |
| 3153 | + | |
| 3154 | + | |
| 3155 | + | |
| 3156 | + | |
| 3157 | + | |
| 3158 | + | |
| 3159 | + | |
| 3160 | + | |
| 3161 | + | |
| 3162 | + | |
| 3163 | + | |
| 3164 | + | |
| 3165 | + | |
| 3166 | + | |
| 3167 | + | |
| 3168 | + | |
| 3169 | + | |
| 3170 | + | |
| 3171 | + | |
| 3172 | + | |
| 3173 | + | |
| 3174 | + | |
| 3175 | + | |
| 3176 | + | |
| 3177 | + | |
| 3178 | + | |
3104 | 3179 | | |
3105 | 3180 | | |
3106 | 3181 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
53 | 58 | | |
54 | 59 | | |
55 | 60 | | |
| |||
138 | 143 | | |
139 | 144 | | |
140 | 145 | | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
141 | 156 | | |
142 | 157 | | |
143 | 158 | | |
| |||
306 | 321 | | |
307 | 322 | | |
308 | 323 | | |
| 324 | + | |
309 | 325 | | |
310 | 326 | | |
311 | 327 | | |
| |||
442 | 458 | | |
443 | 459 | | |
444 | 460 | | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
445 | 470 | | |
446 | 471 | | |
447 | 472 | | |
| |||
474 | 499 | | |
475 | 500 | | |
476 | 501 | | |
477 | | - | |
| 502 | + | |
478 | 503 | | |
| 504 | + | |
479 | 505 | | |
480 | 506 | | |
481 | 507 | | |
482 | 508 | | |
483 | 509 | | |
484 | 510 | | |
485 | 511 | | |
| 512 | + | |
486 | 513 | | |
487 | 514 | | |
488 | 515 | | |
| |||
497 | 524 | | |
498 | 525 | | |
499 | 526 | | |
| 527 | + | |
500 | 528 | | |
501 | 529 | | |
502 | 530 | | |
| |||
511 | 539 | | |
512 | 540 | | |
513 | 541 | | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
514 | 550 | | |
515 | 551 | | |
516 | 552 | | |
| |||
543 | 579 | | |
544 | 580 | | |
545 | 581 | | |
| 582 | + | |
546 | 583 | | |
547 | 584 | | |
548 | 585 | | |
| |||
556 | 593 | | |
557 | 594 | | |
558 | 595 | | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
559 | 600 | | |
560 | 601 | | |
561 | 602 | | |
| |||
571 | 612 | | |
572 | 613 | | |
573 | 614 | | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
574 | 619 | | |
575 | 620 | | |
576 | 621 | | |
| |||
600 | 645 | | |
601 | 646 | | |
602 | 647 | | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
603 | 674 | | |
604 | 675 | | |
605 | 676 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
| 124 | + | |
123 | 125 | | |
124 | 126 | | |
125 | 127 | | |
| |||
387 | 389 | | |
388 | 390 | | |
389 | 391 | | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
390 | 399 | | |
391 | 400 | | |
392 | 401 | | |
| |||
434 | 443 | | |
435 | 444 | | |
436 | 445 | | |
| 446 | + | |
437 | 447 | | |
438 | 448 | | |
439 | 449 | | |
| |||
477 | 487 | | |
478 | 488 | | |
479 | 489 | | |
| 490 | + | |
480 | 491 | | |
481 | 492 | | |
482 | 493 | | |
| |||
713 | 724 | | |
714 | 725 | | |
715 | 726 | | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
716 | 731 | | |
717 | 732 | | |
718 | 733 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| |||
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
43 | | - | |
| 44 | + | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| |||
112 | 113 | | |
113 | 114 | | |
114 | 115 | | |
| 116 | + | |
| 117 | + | |
115 | 118 | | |
116 | 119 | | |
117 | 120 | | |
| |||
177 | 180 | | |
178 | 181 | | |
179 | 182 | | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
180 | 191 | | |
181 | 192 | | |
182 | 193 | | |
| |||
275 | 286 | | |
276 | 287 | | |
277 | 288 | | |
| 289 | + | |
278 | 290 | | |
279 | 291 | | |
280 | 292 | | |
| |||
0 commit comments