Repository navigation
Commit cf048ac
Michael Feth
fix(desktop): fix live-path notify gap and surface circuit badge in the real Agents view
An adversarial review of the circuit-breaker badge (890cfb6) found two
issues, both confirmed by independently tracing the actual code:
- processLiveObserverEvents gated notifyListeners() solely on
appendAgentEvents' return value, discarding applyCircuitEvent's own
changed flag. appendAgentEvents' per-agent eviction floor and
applyCircuitEvent's per-slot ordering gate compare against different
reference points, so a circuit-only change could be committed to the
store without ever notifying useAgentCircuitStatus subscribers. OR
the two signals together, matching every other ingestion path in the
file. Added a regression test reproducing the divergence via a raw-
journal dedup collision (cheaper to construct than real eviction).
- The badge was wired into ManagedAgentRow/AgentGroupRows, but that
component tree has no import anywhere outside itself — it is not
mounted on the app's actual Agents route. The real reachable screen
(AgentsScreen -> AgentsView -> UnifiedAgentsSection, rendering
AgentPersonaCard/StandaloneAgentCard) had no circuit-status wiring at
all, so the feature had no effect in the running app. Added the same
badge to both card components' existing statusBadge slot, taking
priority over the "Configuration missing" badge when both apply.
Left ManagedAgentRow's badge in place (still covered by its own
tests) rather than deciding unilaterally whether that component tree
is dead code or a future integration point.
Signed-off-by: Michael Feth <[email protected]>1 parent 890cfb6 commit cf048ac
3 files changed
Lines changed: 90 additions & 4 deletions
File tree
- desktop/src/features/agents
- ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
207 | 208 | | |
208 | 209 | | |
209 | 210 | | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
210 | 261 | | |
211 | 262 | | |
212 | 263 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
427 | 427 | | |
428 | 428 | | |
429 | 429 | | |
430 | | - | |
| 430 | + | |
431 | 431 | | |
432 | 432 | | |
433 | | - | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
434 | 444 | | |
435 | 445 | | |
436 | 446 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
258 | 259 | | |
259 | 260 | | |
260 | 261 | | |
| 262 | + | |
261 | 263 | | |
262 | 264 | | |
263 | 265 | | |
| |||
322 | 324 | | |
323 | 325 | | |
324 | 326 | | |
325 | | - | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
326 | 340 | | |
327 | 341 | | |
328 | 342 | | |
| |||
355 | 369 | | |
356 | 370 | | |
357 | 371 | | |
| 372 | + | |
358 | 373 | | |
359 | 374 | | |
360 | 375 | | |
| |||
402 | 417 | | |
403 | 418 | | |
404 | 419 | | |
405 | | - | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
406 | 431 | | |
407 | 432 | | |
408 | 433 | | |
| |||
0 commit comments