Skip to content

Comments

SVG stroke review#5

Merged
meyerweb merged 1 commit intomeyerweb:css/strokesfrom
mdn:meyeredits
Aug 26, 2024
Merged

SVG stroke review#5
meyerweb merged 1 commit intomeyerweb:css/strokesfrom
mdn:meyeredits

Conversation

@estelle
Copy link

@estelle estelle commented Aug 21, 2024

I made a bunch of suggested changes, and figured this was an easier way to suggest them. It was an excellent read and i learned a lot.

  • All examples:
    • add intro sentence,
    • html, css, and results headings,
    • moving description of results to after the example is shown
    • Optional (I didn't do this edit) you can remove the xmlns from the last four docs (it's not in the examples in the first 3)
  • Intro paragraphs:
    • added SVG mention with a link to SVG page.
    • added that the property overrides the attribute
    • paragraph break between intro sentence and the inheritance sentence.
  • Syntax:
    • separated out keywords (if any) from other values
    • in one spec i read some did not support numbers, in others they did support number, but i had already removed number (no unit) hence the order change in some cases
    • added headers to the sections (i.e. "Numeric, length, and percentage values" and "Keyword values"
  • Values
    • added a summary paragraph in some cases
    • separated length and percentage in all cases
    • added the percent equation (see the r property)
    • changed "The default value" to "This is the default value." to match other pages
  • See also
    • Included all the stroke-* properties.
    • only included prefix and suffix if the link was not a css property

In linejoin, the spec indicates a two-value syntax, but browsers aren't supporting that. I separated the values section into two chunks: supported and not supported. i have seen this done before, but I can't seem to find it and need to call it a day.

in dasharray, i change the example from 6, 6 to 10 5 to so people get a sense that the first value is the line and the second is the gap.

@estelle
Copy link
Author

estelle commented Aug 21, 2024

also removed an outdated note in the attribute page and added some see alsos there.

@meyerweb meyerweb merged commit c7df6a5 into meyerweb:css/strokes Aug 26, 2024
@Josh-Cena Josh-Cena deleted the meyeredits branch August 26, 2024 16:09
@estelle estelle restored the meyeredits branch August 26, 2024 19:22
@estelle estelle deleted the meyeredits branch August 26, 2024 19:22
meyerweb added a commit that referenced this pull request Aug 27, 2024
* Add stroke-* CSS SVG properties

* Fix up redirects

* SVG stroke review (#5)

* Corrected description of number values

* Corrected capitalization

* Value rearrangement

* Typo correction

* Formatting cleanup

* Tweaks to miterlimit

---------

Co-authored-by: Estelle Weyl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants