User defined mongo connection options API for #6958#7277
User defined mongo connection options API for #6958#7277benjamn merged 1 commit intometeor:release-1.4from
Conversation
packages/mongo/mongo_driver.js
Outdated
There was a problem hiding this comment.
Has this poolSize option changed? If so we should probably fix this
There was a problem hiding this comment.
Only in how you pass it in, the new mongo driver takes care of where it needs to go
There was a problem hiding this comment.
Does the old code work though? It seems surprising that this passed our testing of the new driver..
There was a problem hiding this comment.
Oh right yeah, well as far as I've looked into things it seems like legacy options will work just fine, though I'm not totally sure what happens with safe, I think it may just be ignored as it's the default on later Mongo, but I could be wrong.
There was a problem hiding this comment.
Maybe remove this from the PR then, I think it muddies the waters a little
|
Looking good @dburles |
|
For reference here's the relevant docs for the newer options http://mongodb.github.io/node-mongodb-native/2.1/reference/connecting/connection-settings/ |
dburles
changed the title
packages/mongo/connection_options.js
Outdated
There was a problem hiding this comment.
Can we add a link to the mongo docs so people know what these options are?
dburles
force-pushed
the
mongo-connection-options
branch
from
baec319 to
edb56af
Compare
|
Just a heads up, this was definitely merged, but for some reason now it's not included in the |
|
Any idea what happened here @benjamn? |
User-defined Mongo.setConnectionOptions API for #6958.
|
Not sure why it disappeared, but I've cherry-picked it back onto release-1.4: 2654fe6 |
3 participants
For #6958
I noticed the API has changed for a bunch of the existing options used in
mongo_driver.jssuch as{ safe: true }now replaced by: https://docs.mongodb.com/manual/core/replica-set-write-concern/ but that is a bit out of scope for this PR. Maybe something to be looked at though.