Skip to content

[Work in progress] Upgrade to Node 4 #6921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjamn merged 25 commits into from
May 10, 2016
Merged

[Work in progress] Upgrade to Node 4 #6921

benjamn merged 25 commits into from
May 10, 2016

Conversation

@benjamn
Copy link
Contributor

@benjamn benjamn commented Apr 27, 2016 •
edited
Loading

This pull request targets the wip-upgrade-node branch, and will include any changes that help with upgrading Meteor's bundled version of Node to version ~4.4.3, which is the latest LTS release.

This PR will remain open until Meteor is completely stable on Node 4, but changes that make sense for any version of Node (4, 5, or 6) will get merged into the target branch earlier.

Equivalent PR for Node ~5.11.0: #6922
Equivalent PR for Node ~6.0.0: #6923

@benjamn benjamn self-assigned this Apr 27, 2016
@benjamn benjamn added this to the Release 1.4 milestone Apr 27, 2016
@martijnwalraven martijnwalraven added the in-development We are already working on it label Apr 27, 2016
This was referenced Apr 27, 2016
Closed
Closed
This was referenced Apr 27, 2016
Closed
Closed
@benjamn benjamn force-pushed the wip-upgrade-to-node-4 branch 5 times, most recently from 70f712a to 6bf8169 Compare May 3, 2016 03:23
@benjamn benjamn force-pushed the wip-upgrade-node branch from 39496d1 to df89594 Compare May 6, 2016 17:16
@benjamn benjamn force-pushed the wip-upgrade-to-node-4 branch from 6bf8169 to 9bc6f9a Compare May 6, 2016 17:21
@benjamn benjamn force-pushed the wip-upgrade-node branch from df89594 to 26abdca Compare May 7, 2016 17:43
@benjamn benjamn force-pushed the wip-upgrade-to-node-4 branch from e84b8e8 to ce6037d Compare May 7, 2016 17:44
benjamn pushed a commit that referenced this pull request May 7, 2016
Make sure process.kill is always called with a numeric PID.
14ce60b 
This appears to be one of the biggest changes between Node v0.10 and v4.4
for the Meteor codebase.

Relevant commit:
nodejs/node@832ec1c

Part of #6921.
benjamn pushed a commit that referenced this pull request May 7, 2016
Implement files.exists in terms of file.statOrNull.
5db9036 
The hitherto-underlying fs.exists function has been deprecated in Node v4.

Part of #6921.
benjamn pushed a commit that referenced this pull request May 7, 2016
Cope with asynchronous ChildProcess.prototype.send in Node v4.
5e5770e 
nodejs/node#2620

Part of #6921.
benjamn pushed a commit that referenced this pull request May 7, 2016
Use native path.isAbsolute in Node v4.
76c1c01 
Part of #6921.
@benjamn
Copy link
Contributor Author

benjamn commented May 7, 2016

Once the tests go green, I'm going to merge this pull request into wip-upgrade-node and then rebase #6923 against that.

benjamn pushed a commit that referenced this pull request May 7, 2016
Avoid more uses of fs.exists and fs.existsSync.
a5e0c40 
Part of #6921.
@nathan-muir
Copy link
Contributor

nathan-muir commented May 7, 2016 •
edited
Loading

Hey @benjamn I was about to create a nice clean PR for some of those changes.

  1. You don't need 3221b53 as it's patched in [email protected] - faye/faye-websocket-node@d3340cd
  2. The patch from f03de3f was (probably) unnecessary - you fixed it better in e3c46b6
  3. Missing patch - I still had errors with node-aes-gcm, which were resolved by updating from 0.1.3 to 0.1.6 - try meteor add oauth-encryption or something else that uses it to see the node-(pre-)gyp errors.

Otherwise, I think you've got fixes for all of the other error I've encountered thus far.

@nathan-muir
Copy link
Contributor

nathan-muir commented May 7, 2016

@benjamn nathan-muir@659ad5d

@benjamn benjamn mentioned this pull request May 8, 2016
Closed
@abernix abernix mentioned this pull request May 10, 2016
Closed
@benjamn benjamn force-pushed the wip-upgrade-node branch from 26abdca to 3a5ee28 Compare May 10, 2016 14:24
@benjamn benjamn force-pushed the wip-upgrade-to-node-4 branch from dca6cce to 7d6a20a Compare May 10, 2016 14:24
benjamn pushed a commit that referenced this pull request May 10, 2016
Make sure process.kill is always called with a numeric PID.
f4687a9 
This appears to be one of the biggest changes between Node v0.10 and v4.4
for the Meteor codebase.

Relevant commit:
nodejs/node@832ec1c

Part of #6921.
@rickmed
Copy link

rickmed commented May 19, 2016 •
edited
Loading

@benjamn should this work? I tried the wip-upgrade-node branch on windows but I get

meteor\dev_bundle\lib\node_modules\meteor-promise\promise_server.js:165
  throw error;
      ^

TypeError: p.replace is not a function

Sorry if this is not the issue to put this.

PS: it's using dev_bundle for windows_x86 version 4.0.2

@benjamn
Copy link
Contributor Author

benjamn commented May 20, 2016

Try the release-1.4 branch?

@rickmed
Copy link

rickmed commented May 20, 2016

@benjamn no dice, same error....

@abernix abernix mentioned this pull request May 21, 2016
Closed
benjamn pushed a commit that referenced this pull request May 27, 2016
Cope with asynchronous ChildProcess.prototype.send in Node v4.
fc1dcfe 
nodejs/node#2620

Part of #6921.
benjamn pushed a commit that referenced this pull request May 27, 2016
Use native path.isAbsolute in Node v4.
f3ca08d 
Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 1, 2016
Cope with asynchronous ChildProcess.prototype.send in Node v4.
e2dea84 
nodejs/node#2620

Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 1, 2016
Use native path.isAbsolute in Node v4.
d7f6fb4 
Part of #6921.
@charlieman charlieman mentioned this pull request Jun 3, 2016
Closed
benjamn pushed a commit that referenced this pull request Jun 7, 2016
Cope with asynchronous ChildProcess.prototype.send in Node v4.
5394eac 
nodejs/node#2620

Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 7, 2016
Use native path.isAbsolute in Node v4.
2498b80 
Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 9, 2016
Cope with asynchronous ChildProcess.prototype.send in Node v4.
4d9c0b3 
nodejs/node#2620

Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 9, 2016
Use native path.isAbsolute in Node v4.
4326fe9 
Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 14, 2016
Cope with asynchronous ChildProcess.prototype.send in Node v4.
4ae729e 
nodejs/node#2620

Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 14, 2016
Use native path.isAbsolute in Node v4.
003b5bb 
Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 14, 2016
Cope with asynchronous ChildProcess.prototype.send in Node v4.
e03a9e2 
nodejs/node#2620

Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 14, 2016
Use native path.isAbsolute in Node v4.
68c7010 
Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 14, 2016
Cope with asynchronous ChildProcess.prototype.send in Node v4.
6972950 
nodejs/node#2620

Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 14, 2016
Use native path.isAbsolute in Node v4.
153486a 
Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 23, 2016
Cope with asynchronous ChildProcess.prototype.send in Node v4.
12e983b 
nodejs/node#2620

Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 23, 2016
Use native path.isAbsolute in Node v4.
ce4a6fe 
Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 23, 2016
Cope with asynchronous ChildProcess.prototype.send in Node v4.
783843f 
nodejs/node#2620

Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 23, 2016
Use native path.isAbsolute in Node v4.
330eb30 
Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 24, 2016
Cope with asynchronous ChildProcess.prototype.send in Node v4.
08f074d 
nodejs/node#2620

Part of #6921.
benjamn pushed a commit that referenced this pull request Jun 24, 2016
Use native path.isAbsolute in Node v4.
bf2d2dc 
Part of #6921.
@HLFH HLFH mentioned this pull request Nov 21, 2016
Closed
This was referenced Feb 7, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@benjamn benjamn

Labels

in-development We are already working on it

Projects

None yet

Milestone

Release 1.4

Development

Successfully merging this pull request may close these issues.

5 participants

@benjamn @nathan-muir @rickmed @martijnwalraven