Repository navigation
Conversation
kubeadm sets the node.kubernetes.io/exclude-from-external-load-balancers label on control-plane nodes, and the speaker skips L2 announcements from labeled nodes. An L2Advertisement whose nodeSelectors match only control-plane nodes therefore announces from no node at all, and the only trace is a debug log line from the speaker. Add a note to the L2 nodeSelectors section that explains this and points to the --ignore-exclude-lb flag. Also list the label among the reasons a speaker does not advertise a service in the troubleshooting guide. Signed-off-by: YoungjuKim <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the documentation change about the exclude-from-external-load-balancers label and L2 node selectors. |
| Description check | |
The description includes the documentation classification, purpose, detailed change summary, reviewer notes, and a NONE release note. It matches the repository template and explains the affected confi… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
This PR has been automatically marked as stale because it has been open 30 days
|
Is this a BUG FIX or a FEATURE ?:
/kind documentation
What this PR does / why we need it:
kubeadm sets the
node.kubernetes.io/exclude-from-external-load-balancerslabel on control-plane nodes, and the speaker skips L2 announcements from labeled nodes unless it runs with--ignore-exclude-lb. If anL2AdvertisementhasnodeSelectorsthat match only control-plane nodes, no node announces the IP. The service gets an external IP but is not reachable, and the only trace is a debug-level log line in the speaker (the log was added in #2538 for #2505).The troubleshooting guide already has a section about this label, but the L2
nodeSelectorsdocumentation does not mention it, and the "A given speaker won't advertise the service if" list in the troubleshooting guide does not include it.This PR:
nodeSelectorspart of the advanced L2 configuration page that explains the interaction and points to--ignore-exclude-lb(speaker.ignoreExcludeLBin the Helm chart);Documentation only. No code change.
Special notes for your reviewer:
The PR template asks to open an issue first for non-trivial changes. This is a small documentation change, so I opened the PR directly. I am happy to open an issue if you prefer.
This change was drafted with AI assistance and reviewed by me.
Release note:
🤖 Generated with Claude Code
Summary by CodeRabbit
node.kubernetes.io/exclude-from-external-load-balancers, even when those nodes match anL2Advertisementselector.