Skip to content

ClickHouse Driver Module#9469

Closed
enqueue wants to merge 21 commits intometabase:masterfrom
enqueue:clickhouse_module_2
Closed

ClickHouse Driver Module#9469
enqueue wants to merge 21 commits intometabase:masterfrom
enqueue:clickhouse_module_2

Conversation

@enqueue
Copy link
Copy Markdown

@enqueue enqueue commented Feb 21, 2019

Sorry to create yet another PR for ClickHouse driver (#3332). I tried to contribute to #8722 but the branch seems to have stalled.

@enqueue enqueue mentioned this pull request Feb 21, 2019
@enqueue enqueue mentioned this pull request Mar 5, 2019
@tlrobinson
Copy link
Copy Markdown
Contributor

Hey all,

Thank you for this PR and apologies for the long delay responding. We've recently done some work to support drivers as plugins in Metabase and as of the next release (v0.32) we will be asking driver developers to first publish new drivers in their own repositories (typically named metabase-*-driver). If the driver fully passes the driver tests we will link to it from our documentation, and if a driver gains significant usage we will consider merging it into Metabase itself.

Here is some documentation about publishing a driver as a plugin in a separate repository: https://github.com/metabase/metabase/wiki/Writing-a-Driver:-Packaging-a-Driver-&-Metabase-Plugin-Basics#drivers-shipped-as-3rd-party-plugins

Here are two example drivers: https://github.com/metabase/sudoku-driver https://github.com/metabase/crate-driver

We still have some work to do on the documentation. You can follow progress and provide feedback on that here: #9348

Thank you.

@tlrobinson tlrobinson closed this Mar 11, 2019
@tlrobinson
Copy link
Copy Markdown
Contributor

By the way, I noticed there's another Clickhouse driver: #8491 You all may want to consider consolidating efforts.

@tlrobinson tlrobinson mentioned this pull request Mar 11, 2019
@enqueue
Copy link
Copy Markdown
Author

enqueue commented Mar 11, 2019

@tlrobinson thank you for your feedback. I will try and create a new repository for the plug-in. This PR is actually based on the work of others in #8491 but that PR was never closed.

@nicokruger
Copy link
Copy Markdown

Hi @enqueue did you ever get around to creating a seperate repository for this?

@flamber
Copy link
Copy Markdown
Contributor

flamber commented Apr 10, 2019

@dannyeuu
Copy link
Copy Markdown

dannyeuu commented Apr 8, 2020

@tlrobinson How working with plugins will work for now on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants