Regarding the NPE: This is probably due to the JDBC driver returning a null result set for queries starting with comments, e. g. -- MetaBase\n SELECT 42 I created PR ClickHouse/clickhouse-java#256 to counter this.

Regarding the test data, I would like to ask @camsaul for advice: The test-data/checkins table has a date column defined with type base-type :type/Date. Then data is loaded via a timestamp, e.g. #inst "2014-09-15T07 resulting in 2014-09-15 07:00:00 on the wire. This is rejected by the ClickHouse server because it cannot parse this input as a Date ("Date must be in YYYY-MM-DD format"). What is expected of the driver in this case? What would be the right place in the code to adjust the format of the timestamp depending on the target column type when loading data?

@ei-grad is there a way for me to create a PR against this branch that is already rebased on master? See changes in enqueue/clickhouse_update

We are far away from completion (ca. 40 tests still failing), but if you compile JDBC driver including your changes ClickHouse/clickhouse-java#247 you will be able to play around with the database and perhaps improve the driver further ;-)

@enqueue rebased, moved the project.clj change to separate commit to easier rebase in future.

Merged, removed the TODO_clickhouse.txt file, not sure if it should go in the source tree, it is better to put it here, imo (added to the PR first comment).

When I run the tests with ENGINES=h2,clickhouse lein test the result is:

Ran 3446 tests containing 3342 assertions in 91516 msecs
1 failures, 8 errors.

Did something changed with running the tests?..

There are some buggy empty extra fields in clickhouse driver configuration UI:
https://user-images.githubusercontent.com/78607/49041850-6932ce00-f1d7-11e8-9654-282f5f9da920.png

@enqueue I didn't have a look to the latest driver structure refactoring yet, do you have any ideas why this extra fields appeared? ^

@ei-grad thanks for your help! Let's try to get this PR ready for christmas...

• Will remove TODO_clickhouse.txt when we are done with this branch (unless we forget ;-) )
• You have to run the tests using DRIVERS=h2,ClickHouse instead of ENGINE
• I do not know about the buggy extra fields. Are these specific to ClickHouse driver?

The previous comment is obsolete because the structure has changed. Unfortunately this PR seems to have stalled, so I have added the current state of my branch as PR #9469

Hi. Does anyone working on finishing this effort? Specifically on porting to new plugin system?

Hello @CheatEx I have been working on this driver, and refactored it for the new module structure. Unfortunately I cannot update this PR myself (see ei-grad#6). If you want to check out a more recent version, see clickhouse_module_2 branch. What should I do?

imho it should be rebased to new PR :/
@ei-grad, @enqueue WDYT?