Call .wait_tensor() in compiled region for dist.Work created in eager region #2485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64275115 |
Microve
force-pushed
the
export-D64275115
branch
from
a7df96c to
5c54383
Compare
Microve
pushed a commit
to Microve/torchrec
that referenced
this pull request
Oct 22, 2024
… region (meta-pytorch#2485) Summary: In compiled region, instead of calling `dist.Work.wait()`, we will call `torch.ops._c10d_functional.wait_tensor()` on the dist.Work's output tensor. This way, we can capture the `wait_tensor()` op within the torch.compile graph (instead of graph-breaking on `dist.Work.wait()`), and the tensor will be waited on properly within the graph. This diff also depends on pytorch/pytorch#137763 to function properly. Reviewed By: Microve Differential Revision: D64275115
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64275115 |
Microve
pushed a commit
to Microve/torchrec
that referenced
this pull request
Oct 26, 2024
… region (meta-pytorch#2485) Summary: In compiled region, instead of calling `dist.Work.wait()`, we will call `torch.ops._c10d_functional.wait_tensor()` on the dist.Work's output tensor. This way, we can capture the `wait_tensor()` op within the torch.compile graph (instead of graph-breaking on `dist.Work.wait()`), and the tensor will be waited on properly within the graph. This diff also depends on pytorch/pytorch#137763 to function properly. Reviewed By: Microve Differential Revision: D64275115
Microve
force-pushed
the
export-D64275115
branch
from
5c54383 to
c5137f6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64275115 |
Microve
force-pushed
the
export-D64275115
branch
from
c5137f6 to
31c90e3
Compare
Microve
pushed a commit
to Microve/torchrec
that referenced
this pull request
Nov 1, 2024
… region (meta-pytorch#2485) Summary: In compiled region, instead of calling `dist.Work.wait()`, we will call `torch.ops._c10d_functional.wait_tensor()` on the dist.Work's output tensor. This way, we can capture the `wait_tensor()` op within the torch.compile graph (instead of graph-breaking on `dist.Work.wait()`), and the tensor will be waited on properly within the graph. This diff also depends on pytorch/pytorch#137763 to function properly. Reviewed By: Microve Differential Revision: D64275115
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64275115 |
… region (meta-pytorch#2485) Summary: In compiled region, instead of calling `dist.Work.wait()`, we will call `torch.ops._c10d_functional.wait_tensor()` on the dist.Work's output tensor. This way, we can capture the `wait_tensor()` op within the torch.compile graph (instead of graph-breaking on `dist.Work.wait()`), and the tensor will be waited on properly within the graph. This diff also depends on pytorch/pytorch#137763 to function properly. Reviewed By: Microve Differential Revision: D64275115
Microve
force-pushed
the
export-D64275115
branch
from
31c90e3 to
fed098a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64275115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In compiled region, instead of calling
dist.Work.wait(), we will calltorch.ops._c10d_functional.wait_tensor()on the dist.Work's output tensor. This way, we can capture thewait_tensor()op within the torch.compile graph (instead of graph-breaking ondist.Work.wait()), and the tensor will be waited on properly within the graph.This diff also depends on pytorch/pytorch#137763 to function properly.
Differential Revision: D64275115