Update LRScheduler instance checks#271
Closed
ananthsub wants to merge 2 commits intometa-pytorch:masterfrom
Closed
Update LRScheduler instance checks#271ananthsub wants to merge 2 commits intometa-pytorch:masterfrom
ananthsub wants to merge 2 commits intometa-pytorch:masterfrom
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41177335 |
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 89.04% 89.11% +0.06%
==========================================
Files 85 85
Lines 5305 5374 +69
==========================================
+ Hits 4724 4789 +65
- Misses 581 585 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ananthsub
added a commit
to ananthsub/tnt
that referenced
this pull request
Nov 15, 2022
Summary: Pull Request resolved: meta-pytorch#271 After pytorch/pytorch#88503 , these isinstance checks no longer pass. Example: https://github.com/pytorch/tnt/actions/runs/3434539858/jobs/5725945075 Reviewed By: janeyx99 Differential Revision: D41177335 fbshipit-source-id: 243b2fb4cdb06561588b56a9a9f08a7144c6ae9b
ananthsub
force-pushed
the
export-D41177335
branch
from
d2a29de to
bc13917
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41177335 |
Differential Revision: D41297006 fbshipit-source-id: 284d2bebf77d57ae73861b3f353c20a3346a4d2e
Summary: Pull Request resolved: meta-pytorch#271 After pytorch/pytorch#88503 , these isinstance checks no longer pass. Example: https://github.com/pytorch/tnt/actions/runs/3434539858/jobs/5725945075 Reviewed By: janeyx99 Differential Revision: D41177335 fbshipit-source-id: c09398e06bebc2e9362f369143d4d8dd7c21e6e6
ananthsub
force-pushed
the
export-D41177335
branch
from
bc13917 to
00bb919
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41177335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
After pytorch/pytorch#88503 , these isinstance checks no longer pass. Example: https://github.com/pytorch/tnt/actions/runs/3434539858/jobs/5725945075
Differential Revision: D41177335