Closed
Conversation
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ejguan
approved these changes
Mar 22, 2022
Contributor
ejguan
left a comment
ejguan
left a comment
There was a problem hiding this comment.
Thanks for fixing it. A nit comment to make this workflow better.
.github/workflows/docs.yml
Outdated
Comment on lines
+23
to
+24
| python3 -m pip install -r https://raw.githubusercontent.com/pytorch/data/main/requirements.txt | ||
| python3 -m pip install --no-build-isolation git+https://github.com/pytorch/data |
Contributor
There was a problem hiding this comment.
You can add a separate step to compile torchdata from local source as we have a prior step which has already checked out torchdata repo.
python3 -m pip install -r requirements.txt
python3 setup.py install
Fixing the issue [mentioned here](#290 (comment)). I have ran it on my fork and the build worked: https://github.com/NivekT/data/actions/runs/2023027716 Differential Revision: [D35048050](https://our.internmc.facebook.com/intern/diff/D35048050) [ghstack-poisoned]
Contributor
Author
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixing the issue mentioned here.
I have ran it on my fork and the build worked:
https://github.com/NivekT/data/actions/runs/2023027716
Differential Revision: D35048050