Rename BucketBatcher argument to avoid name collision#304
Rename BucketBatcher argument to avoid name collision#304NivekT wants to merge 4 commits intogh/NivekT/63/basefrom
Conversation
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
ejguan
left a comment
ejguan
left a comment
There was a problem hiding this comment.
Thanks for fixing it.
I was also thinking to change the name of this DataPipe to Bucketizer with functional name bucketize in favor of this commonly used name (https://www.tensorflow.org/tfx/transform/api_docs/python/tft/bucketize)
I think that seems reasonable. We will have to go through the deprecation process. |
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
We have a DataPipe using the functional API name `in_batch_shuffle`. Therefore, this DataPipe should **not** have a class variable with the same name to avoid confusion. Differential Revision: [D34939045](https://our.internmc.facebook.com/intern/diff/D34939045) [ghstack-poisoned]
We have a DataPipe using the functional API name `in_batch_shuffle`. Therefore, this DataPipe should **not** have a class variable with the same name to avoid confusion. Differential Revision: [D34939045](https://our.internmc.facebook.com/intern/diff/D34939045) [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
We have a DataPipe using the functional API name `in_batch_shuffle`. Therefore, this DataPipe should **not** have a class variable with the same name to avoid confusion. Differential Revision: [D34939045](https://our.internmc.facebook.com/intern/diff/D34939045) [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
3 participants
Stack from ghstack:
We have a DataPipe using the functional API name
in_batch_shuffle. Therefore, this DataPipe should not have a class variable with the same name to avoid confusion.Differential Revision: D34939045