Repository navigation
Conversation
…ock_cache_compressed The comment still describes behaviour from before 7.0: the third "bloomfilter" field is ignored now, "ribbonfilter" is accepted, and block_cache_compressed is deprecated and has no effect. Signed-off-by: YoungjuKim <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The comment that explains how to set
filter_policyandblock_cacheby string inGetBlockBasedTableOptionsFromMap()(include/rocksdb/convenience.h, with a copy intable/block_based/block_based_table_factory.cc) still describes behavior from before RocksDB 7.0 and 8.0:"bloomfilter:[bits_per_key]:[use_block_based_builder]"and gives"bloomfilter:4:true"as an example "with use_block_based_builder enabled". Since 7.0 the second field is ignored (filter_policy.h: "As of RocksDB 7.0, the use_block_based_builder parameter is ignored"), andoptions_test.ccalready asserts thatbloomfilter:4:truegives the same policy asbloomfilter:4."ribbonfilter:[bits_per_key]"and"ribbonfilter:[bits_per_key]:[bloom_before_level]"are also accepted (registered inRegisterBuiltinFilterPolicies, covered byoptions_test.cc).block_cache_compressednext toblock_cache. That option was removed and is now parsed askDeprecated, which means it is accepted and ignored.This PR updates both copies of the comment: it drops the boolean from the Bloom syntax and example, documents the Ribbon syntax, and notes that
block_cache_compressedis ignored. Only comments change, not code.Test Plan
Comments only. I checked each statement against
table/block_based/filter_policy.cc,table/block_based/block_based_table_factory.ccand the existing assertions inoptions/options_test.cc(OptionsTest, GetBlockBasedTableOptionsFromString). I did not build RocksDB for this change.This change was prepared with the help of an AI assistant (Claude); I reviewed and verified it.
🤖 Generated with Claude Code